feat: distinct function selector for new domain on RoutingISM #5219
Conversation
🦋 Changeset detectedLatest commit: a5ea9d9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 9 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
yorhodes
changed the title
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## audit-q1-2025 #5219 +/- ##
================================================
Coverage ? 77.72%
================================================
Files ? 104
Lines ? 2137
Branches ? 192
================================================
Hits ? 1661
Misses ? 455
Partials ? 21
|
| for (uint256 i = 0; i < _length; ++i) { | ||
| _set(_domains[i], address(__modules[i])); | ||
| } | ||
| _set(_domains, __modules); |
Check warning
Code scanning / Olympix Integrated Security
Test functions fail to verify specific revert reasons, potentially missing important contract behavior validation. For more information, visit: http://detectors.olympixdevsectools.com/article/web3-vulnerability/missing-revert-reason-tests Medium
| IInterchainSecurityModule[] calldata __modules | ||
| ) internal { | ||
| require(_domains.length == __modules.length, "length mismatch"); | ||
| uint256 _length = _domains.length; |
Check notice
Code scanning / Olympix Integrated Security
Local variables in test functions are not properly fuzzed, potentially reducing the effectiveness of property-based testing. For more information, visit: http://detectors.olympixdevsectools.com/article/web3-vulnerability/unfuzzed-local-variables Low
| ) internal { | ||
| require(_domains.length == __modules.length, "length mismatch"); | ||
| uint256 _length = _domains.length; | ||
| for (uint256 i = 0; i < _length; ++i) { |
Check notice
Code scanning / Olympix Integrated Security
Local variables in test functions are not properly fuzzed, potentially reducing the effectiveness of property-based testing. For more information, visit: http://detectors.olympixdevsectools.com/article/web3-vulnerability/unfuzzed-local-variables Low
| ) internal { | ||
| require(_domains.length == __modules.length, "length mismatch"); | ||
| uint256 _length = _domains.length; | ||
| for (uint256 i = 0; i < _length; ++i) { |
Check notice
Code scanning / Olympix Integrated Security
Local variables in test functions are not properly fuzzed, potentially reducing the effectiveness of property-based testing. For more information, visit: http://detectors.olympixdevsectools.com/article/web3-vulnerability/unfuzzed-local-variables Low
| } | ||
|
|
||
| function _add(uint32 _domain, address _module) internal { | ||
| require(!_modules.contains(_domain), "Domain already exists"); |
Check warning
Code scanning / Olympix Integrated Security
Test functions fail to verify specific revert reasons, potentially missing important contract behavior validation. For more information, visit: http://detectors.olympixdevsectools.com/article/web3-vulnerability/missing-revert-reason-tests Medium
| uint32[] calldata _domains, | ||
| IInterchainSecurityModule[] calldata __modules | ||
| ) external onlyOwner { | ||
| require(_domains.length == __modules.length, "length mismatch"); |
Check warning
Code scanning / Olympix Integrated Security
Test functions fail to verify specific revert reasons, potentially missing important contract behavior validation. For more information, visit: http://detectors.olympixdevsectools.com/article/web3-vulnerability/missing-revert-reason-tests Medium
Description
Introduces a new function selector
addfor adding new domains to a Routing ISM (reverts if this domain already exists). This allows us to have distinct role-based access control foraddandseton anAccessManagerinstance.Drive-by Changes
Adds batch variants of set and add.
Related issues
Backward compatibility
Yes
Testing
Unit Tests