Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(infra): fetch registry on warp monitor startup #5246

Merged
merged 7 commits into from
Jan 23, 2025
Merged

Conversation

paulbalaji
Copy link
Contributor

@paulbalaji paulbalaji commented Jan 22, 2025

Description

feat: fetch registry on warp monitor startup

can describe pod to get the registry commit that a monitor was deployed with

kubectl describe pod hyperlane-warp-route-brett-base-zeronetwork-0 | grep REGISTRY
      REGISTRY_COMMIT:  v6.19.1

Drive-by changes

  • add the entrypoint in monorepo Dockerfile to fetch registry at startup
  • opens the path for removing the registry fetching from the image build entirely, once other monorepo users (e.g. keyfunder/kathy) specify their own registry commit to run with
  • get mailbox addresses from regular registry chain addresses instead of via warp route configs

Related issues

resolves #5174
resolves #5257

Backward compatibility

Testing

  • spun up a BRETT/base-zeronetwork warp monitor
kubectl logs hyperlane-warp-route-brett-base-zeronetwork-0
Updating Hyperlane registry to commit: v6.19.1
From https://github.com/hyperlane-xyz/hyperlane-registry
 * tag               v6.19.1    -> FETCH_HEAD
Previous HEAD position was 80023dd feat: Add OP extension and Trumpchain warp route (#507)
HEAD is now at e87c85f Version Packages (#508)
bigint: Failed to load bindings, pure JS will be used (try npm run rebuild?)
{"level":30,"time":1737556333704,"pid":29,"module":"warp-balance-monitor","labels":{"chain_name":"zeronetwork","token_address":"0xf7F253769c36CC7e1B01988CFf3aE198dea2c172","token_name":"Brett","wallet_address":"0xf7F253769c36CC7e1B01988CFf3aE198dea2c172","token_standard":"EvmHypSynthetic","warp_route_id":"BRETT/base-zeronetwork","related_chain_names":"base"},"balance":1e-18,"msg":"Wallet balance updated for token"}
...
etc

confirmed it's validating the given commit exists
image

Copy link

changeset-bot bot commented Jan 22, 2025

⚠️ No Changeset found

Latest commit: ccd93f0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codecov bot commented Jan 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.53%. Comparing base (ea85aa8) to head (ccd93f0).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5246   +/-   ##
=======================================
  Coverage   77.53%   77.53%           
=======================================
  Files         103      103           
  Lines        2110     2110           
  Branches      190      190           
=======================================
  Hits         1636     1636           
  Misses        453      453           
  Partials       21       21           
Components Coverage Δ
core 87.80% <ø> (ø)
hooks 79.39% <ø> (ø)
isms 83.68% <ø> (ø)
token 91.27% <ø> (ø)
middlewares 79.80% <ø> (ø)

@paulbalaji paulbalaji changed the title [WIP] feat: fetch registry on warp monitor startup feat(infra): enable registry override at monorepo image runtime Jan 22, 2025
@paulbalaji paulbalaji marked this pull request as ready for review January 22, 2025 14:57
@paulbalaji paulbalaji requested a review from nambrot January 22, 2025 14:58
@paulbalaji paulbalaji changed the title feat(infra): enable registry override at monorepo image runtime feat(infra): fetch registry on warp monitor startup Jan 22, 2025
docker-entrypoint.sh Show resolved Hide resolved
@paulbalaji paulbalaji added this pull request to the merge queue Jan 23, 2025
Merged via the queue into main with commit e4c9c7d Jan 23, 2025
42 of 44 checks passed
@paulbalaji paulbalaji deleted the pb/5174 branch January 23, 2025 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
3 participants