Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make decimals() virtual #5254

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

garyghayrat
Copy link
Contributor

Description

This PR makes the decimals() function virtual to allow for further overriding in derived contracts.

Drive-by changes

None.

Related issues

N/A.

Backward compatibility

Yes

Testing

N/A

Copy link

changeset-bot bot commented Jan 22, 2025

⚠️ No Changeset found

Latest commit: 4930c4c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@yorhodes yorhodes changed the title Make decimals() virtual feat: make decimals() virtual Jan 22, 2025
Copy link

codecov bot commented Jan 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.53%. Comparing base (25df8a3) to head (4930c4c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5254   +/-   ##
=======================================
  Coverage   77.53%   77.53%           
=======================================
  Files         103      103           
  Lines        2110     2110           
  Branches      190      190           
=======================================
  Hits         1636     1636           
  Misses        453      453           
  Partials       21       21           
Components Coverage Δ
core 87.80% <ø> (ø)
hooks 79.39% <ø> (ø)
isms 83.68% <ø> (ø)
token 91.27% <100.00%> (ø)
middlewares 79.80% <ø> (ø)

@yorhodes yorhodes enabled auto-merge January 22, 2025 20:36
@yorhodes yorhodes disabled auto-merge January 22, 2025 20:36
@yorhodes yorhodes enabled auto-merge January 22, 2025 23:18
auto-merge was automatically disabled January 22, 2025 23:23

Head branch was pushed to by a user without write access

@garyghayrat garyghayrat force-pushed the token-decimals-virtual branch from 7536049 to 4930c4c Compare January 22, 2025 23:23
@yorhodes yorhodes enabled auto-merge January 22, 2025 23:24
@yorhodes yorhodes added this pull request to the merge queue Jan 22, 2025
Merged via the queue into hyperlane-xyz:main with commit 21bd985 Jan 22, 2025
41 of 45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants