-
Notifications
You must be signed in to change notification settings - Fork 417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: zksync default build artifact #5269
Merged
paulbalaji
merged 37 commits into
hyperlane-xyz:main
from
txfusion:fix/zksync-default-build-artifact
Jan 23, 2025
Merged
fix: zksync default build artifact #5269
paulbalaji
merged 37 commits into
hyperlane-xyz:main
from
txfusion:fix/zksync-default-build-artifact
Jan 23, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljankovic-txfusion
requested review from
yorhodes,
tkporter,
aroralanuk and
ltyu
as code owners
January 23, 2025 11:13
🦋 Changeset detectedLatest commit: 4dafa80 The changes in this PR will be included in the next version bump. This PR includes changesets to release 9 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
paulbalaji
approved these changes
Jan 23, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5269 +/- ##
=======================================
Coverage 77.53% 77.53%
=======================================
Files 103 103
Lines 2110 2110
Branches 190 190
=======================================
Hits 1636 1636
Misses 453 453
Partials 21 21
|
Merged
via the queue into
hyperlane-xyz:main
with commit Jan 23, 2025
11cf66c
41 of 45 checks passed
paulbalaji
added a commit
that referenced
this pull request
Jan 23, 2025
This reverts commit 11cf66c.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The aim of this PR is to satisfy the exports in
package.json
and to ensure that the SDK build command succeeds in the upcoming ZKSync PRs (imported by ContractVerification classes). In thedist
folder, this file is overwritten with the correct values when 'build:zk' is run.Drive-by changes
Related issues
None
Backward compatibility
Yes
Testing
Build passing in the upcoming ZKSync PRs