Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: zksync default build artifact #5269

Merged

Conversation

ljankovic-txfusion
Copy link
Collaborator

Description

The aim of this PR is to satisfy the exports in package.json and to ensure that the SDK build command succeeds in the upcoming ZKSync PRs (imported by ContractVerification classes). In the dist folder, this file is overwritten with the correct values when 'build:zk' is run.

Drive-by changes

  • Default export of buildArtifact as an empty object

Related issues

None

Backward compatibility

Yes

Testing

Build passing in the upcoming ZKSync PRs

mortezashojaei and others added 30 commits October 16, 2024 15:07
Copy link

changeset-bot bot commented Jan 23, 2025

🦋 Changeset detected

Latest commit: 4dafa80

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 9 packages
Name Type
@hyperlane-xyz/core Patch
@hyperlane-xyz/helloworld Patch
@hyperlane-xyz/sdk Patch
@hyperlane-xyz/infra Patch
@hyperlane-xyz/cli Patch
@hyperlane-xyz/widgets Patch
@hyperlane-xyz/ccip-server Patch
@hyperlane-xyz/github-proxy Patch
@hyperlane-xyz/utils Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Jan 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.53%. Comparing base (21bd985) to head (4dafa80).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5269   +/-   ##
=======================================
  Coverage   77.53%   77.53%           
=======================================
  Files         103      103           
  Lines        2110     2110           
  Branches      190      190           
=======================================
  Hits         1636     1636           
  Misses        453      453           
  Partials       21       21           
Components Coverage Δ
core 87.80% <ø> (ø)
hooks 79.39% <ø> (ø)
isms 83.68% <ø> (ø)
token 91.27% <ø> (ø)
middlewares 79.80% <ø> (ø)

@paulbalaji paulbalaji enabled auto-merge January 23, 2025 11:31
@paulbalaji paulbalaji added this pull request to the merge queue Jan 23, 2025
Merged via the queue into hyperlane-xyz:main with commit 11cf66c Jan 23, 2025
41 of 45 checks passed
paulbalaji added a commit that referenced this pull request Jan 23, 2025
github-merge-queue bot pushed a commit that referenced this pull request Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants