-
Notifications
You must be signed in to change notification settings - Fork 424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(balances): Support automatic desired balances and alert thresholds based on daily burn approximations #5270
Conversation
|
typescript/infra/config/environments/mainnet3/balances/dailyBurn.json
Outdated
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5270 +/- ##
=======================================
Coverage 77.53% 77.53%
=======================================
Files 103 103
Lines 2110 2110
Branches 190 190
=======================================
Hits 1636 1636
Misses 453 453
Partials 21 21
|
I have scripts that uses the config to write the alerts into grafana using the API pretty much ready. I wanted to use the opportunity to see how much of a lift it would be to use terraform provisioned alerts. These checked in configs create a nice interface for the grafana API approach vs terraform |
typescript/infra/scripts/funding/update-balance-threshold-config.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As many of the values seem wrong, I think we should have some mechanisms to sanity check them when they're generated, e.g. > 0, ensure that dailyBurn < highUrgencyRelayerBalances < etc
typescript/infra/config/environments/mainnet3/balances/dailyBurn.json
Outdated
Show resolved
Hide resolved
typescript/infra/config/environments/mainnet3/balances/dailyBurn.json
Outdated
Show resolved
Hide resolved
typescript/infra/config/environments/mainnet3/balances/highUrgencyRelayerBalance.json
Outdated
Show resolved
Hide resolved
typescript/infra/config/environments/mainnet3/balances/highUrgencyRelayerBalance.json
Outdated
Show resolved
Hide resolved
typescript/infra/config/environments/mainnet3/balances/highUrgencyRelayerBalance.json
Outdated
Show resolved
Hide resolved
typescript/infra/scripts/funding/update-balance-threshold-config.ts
Outdated
Show resolved
Hide resolved
typescript/infra/scripts/funding/update-balance-threshold-config.ts
Outdated
Show resolved
Hide resolved
typescript/infra/config/environments/mainnet3/balances/dailyRelayerBurn.json
Outdated
Show resolved
Hide resolved
typescript/infra/config/environments/mainnet3/balances/dailyRelayerBurn.json
Outdated
Show resolved
Hide resolved
typescript/infra/config/environments/mainnet3/balances/dailyRelayerBurn.json
Outdated
Show resolved
Hide resolved
typescript/infra/config/environments/mainnet3/balances/dailyRelayerBurn.json
Outdated
Show resolved
Hide resolved
typescript/infra/config/environments/mainnet3/balances/desiredRelayerBalances.json
Outdated
Show resolved
Hide resolved
typescript/infra/config/environments/mainnet3/balances/desiredRelayerBalances.json
Outdated
Show resolved
Hide resolved
typescript/infra/config/environments/mainnet3/balances/desiredRelayerBalances.json
Outdated
Show resolved
Hide resolved
typescript/infra/config/environments/mainnet3/balances/dailyRelayerBurn.json
Show resolved
Hide resolved
typescript/infra/scripts/funding/calculate-relayer-daily-burn.ts
Outdated
Show resolved
Hide resolved
typescript/infra/scripts/funding/update-balance-threshold-config.ts
Outdated
Show resolved
Hide resolved
…ds based on daily burn approximations
9aac39b
to
7cd18a7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mostly lgtm with some nits / file moving
typescript/infra/scripts/funding/calculate-relayer-daily-burn.ts
Outdated
Show resolved
Hide resolved
typescript/infra/scripts/funding/calculate-relayer-daily-burn.ts
Outdated
Show resolved
Hide resolved
9596932
to
5b47ef3
Compare
5b47ef3
to
7570f80
Compare
typescript/infra/config/environments/mainnet3/balances/desiredRelayerBalances.json
Show resolved
Hide resolved
typescript/infra/config/environments/mainnet3/balances/desiredRelayerBalances.json
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice, looking really good - no super huge comments but more trying to understand what to expect after this is merged, like what is the new process for updating an alert atm
Description
dailyBurn.json
lowUrgencyKeyFunderBalance
,highUrgencyRelayerBalance
and writing them to checked in configSupport updating checked in config based on the dailyBurn and multipliers
Support writing alert queries to grafana
Note, the configs are not in use at the moment and will be used as we roll this out
Related issues
Backward compatibility
Testing
Manual