Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: simplify registry override #5271

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

mshojaei-txfusion
Copy link
Collaborator

@mshojaei-txfusion mshojaei-txfusion commented Jan 23, 2025

Description

This PR includes two main improvements to the CLI's registry and parameter handling:

  1. Removes the unused --overrides parameter from all warp command functions, which was previously only used for local testing purposes but is no longer needed.

  2. Enhances the registry handling by:

    • Converting the registry parameter from a single URI to an array structure
    • Adding support for multiple registry sources, later registry takes priority over previous
    • Including default values in the registry array (GitHub and local registry)

These changes simplify the codebase and make the registry configuration more flexible and explicit.

Related issues

#5267

Backward compatibility

Yes - These changes are backward compatible. The removal of the unused --overrides parameter doesn't affect functionality since it was not being actively used. The registry array structure maintains compatibility with existing registry configurations while adding support for multiple sources.

Testing

Manual testing

Copy link

changeset-bot bot commented Jan 23, 2025

⚠️ No Changeset found

Latest commit: ec25141

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@mshojaei-txfusion mshojaei-txfusion force-pushed the refactor/simplify-registry-override branch from bb65215 to ec25141 Compare January 23, 2025 15:45
@mshojaei-txfusion mshojaei-txfusion changed the title Refactor/simplify registry override refactor: simplify registry override Jan 23, 2025
Copy link

codecov bot commented Jan 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.53%. Comparing base (e4c9c7d) to head (ec25141).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5271   +/-   ##
=======================================
  Coverage   77.53%   77.53%           
=======================================
  Files         103      103           
  Lines        2110     2110           
  Branches      190      190           
=======================================
  Hits         1636     1636           
  Misses        453      453           
  Partials       21       21           
Components Coverage Δ
core 87.80% <ø> (ø)
hooks 79.39% <ø> (ø)
isms 83.68% <ø> (ø)
token 91.27% <ø> (ø)
middlewares 79.80% <ø> (ø)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Review
Development

Successfully merging this pull request may close these issues.

2 participants