Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Remove settle secondary (#351)" #398

Conversation

sophia1ch
Copy link
Contributor

This PR is linked to hyperledger-labs/perun-eth-backend#47 and reverts commit be6e072.

@sophia1ch sophia1ch marked this pull request as ready for review February 19, 2024 10:03
@iljabvh iljabvh self-requested a review February 20, 2024 10:06
@@ -37,13 +37,15 @@ PolyCrypt GmbH
Jan Bormet <[email protected]>
Norbert Dzikowski <[email protected]>
Matthias Geihs <[email protected]>
matthiasgeihs <[email protected]>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why would you add my alternative GitHub email here? In particular, since I'm not involved in this PR, this seems wrong. I think the clean way would be to remove the respective author entry from the corresponding commit and force push.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, please don't add any of my GitHub handles without my consent.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry about that. This pull request reverts a commit from your account that included this specific handle in the signature of one of your commits. This caused the copyright test to fail. I'll address this issue promptly. I believe the simplest solution would be to copy the code back in and create a new pull request, since the specific commit hash with this handle seems to be squashed.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, did you try editing commit a865ac5 and changing the author?

Anyhow, it seems like you resolved this somehow differently. Thank you!

@sophia1ch sophia1ch closed this Feb 20, 2024
@sophia1ch sophia1ch deleted the include-secondary-conclude branch February 20, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants