-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Remove settle secondary (#351)" #398
Revert "Remove settle secondary (#351)" #398
Conversation
This reverts commit be6e072. Signed-off-by: sophia1ch <[email protected]>
78b489c
to
a865ac5
Compare
Signed-off-by: sophia1ch <[email protected]>
Signed-off-by: sophia1ch <[email protected]>
Signed-off-by: sophia1ch <[email protected]>
Signed-off-by: sophia1ch <[email protected]>
@@ -37,13 +37,15 @@ PolyCrypt GmbH | |||
Jan Bormet <[email protected]> | |||
Norbert Dzikowski <[email protected]> | |||
Matthias Geihs <[email protected]> | |||
matthiasgeihs <[email protected]> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why would you add my alternative GitHub email here? In particular, since I'm not involved in this PR, this seems wrong. I think the clean way would be to remove the respective author entry from the corresponding commit and force push.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general, please don't add any of my GitHub handles without my consent.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry about that. This pull request reverts a commit from your account that included this specific handle in the signature of one of your commits. This caused the copyright test to fail. I'll address this issue promptly. I believe the simplest solution would be to copy the code back in and create a new pull request, since the specific commit hash with this handle seems to be squashed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, did you try editing commit a865ac5 and changing the author?
Anyhow, it seems like you resolved this somehow differently. Thank you!
This PR is linked to hyperledger-labs/perun-eth-backend#47 and reverts commit be6e072.