Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check denom length on sendTransfer #238

Merged
merged 1 commit into from
Dec 1, 2023
Merged

Check denom length on sendTransfer #238

merged 1 commit into from
Dec 1, 2023

Conversation

yoshidan
Copy link
Contributor

@yoshidan yoshidan commented Dec 1, 2023 •
edited
Loading

slice_outOfBounds occurs when the denom is shorter than the denomPrefix, so the length of the denom is checked.

@yoshidan yoshidan requested a review from a team as a code owner December 1, 2023 11:46
@bluele
Copy link
Member

bluele commented Dec 1, 2023

Thanks, @yoshidan. First, could you rebase the commit　with the latest main?

@yoshidan
check denom length
445a198 
Signed-off-by: yoshidan <[email protected]>
@yoshidan
Copy link
Contributor Author

yoshidan commented Dec 1, 2023

Now I rebased the commit with the latest main.

bluele
bluele approved these changes Dec 1, 2023
View reviewed changes
Copy link
Member

@bluele bluele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, good catch!

@bluele bluele merged commit cef33b3 into hyperledger-labs:main Dec 1, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bluele bluele bluele approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yoshidan @bluele