Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update AppBase inheritance #297

Merged
merged 2 commits into from
Sep 3, 2024
Merged

update AppBase inheritance #297

merged 2 commits into from
Sep 3, 2024

Conversation

3100
Copy link
Member

@3100 3100 commented Sep 3, 2024

This PR updates the inheritance order of AppBase to make it easier for App-layer contracts that inherit from AppBase to utilize OpenZeppelin contracts (such as AccessControl).

@3100 3100 requested a review from a team as a code owner September 3, 2024 06:15
@3100 3100 removed the request for review from a team September 3, 2024 06:15
Signed-off-by: Ryo Sato <[email protected]>
@3100 3100 requested a review from a team September 3, 2024 06:46
Copy link
Member

@bluele bluele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM👍

@bluele bluele merged commit 738ce6c into main Sep 3, 2024
5 checks passed
@bluele bluele deleted the update-appbase-inheritance branch September 3, 2024 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants