Adding erc721 sample #122
Closed
Adding erc721 sample #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: dwertent <[email protected]>
awrichar
requested changes
Jan 21, 2025
There was a problem hiding this comment.
I'm not sure I understand the need for this here. If you have an idea for a new test that leverages Zeto non-fungible alongside ERC-721, perhaps it makes sense to add a unit test here to demonstrate?
Otherwise, if your idea is very specific to Paladin, I think this discussion should be moved to an issue or PR in the Paladin repository.
|
Closing this PR as the addition of ERC721 is not relevant to the Zeto repository. Zeto provides reference implementations for fungible and non-fungible tokens with interfaces tailored specifically to its needs. As such, an ERC721 implementation is unnecessary here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Paladin relies on artifacts published by the Zeto repository.
As part of adding support for non-fungible tokens (NFTs) to Paladin, an ERC721 sample contract needs to be added to the Zeto repository. This will allow it to be used later in Paladin's integration tests.
An alternative approach could involve Paladin maintaining its own list of contracts, independent of Zeto. However, I believe the current design - centralizing the contracts in Zeto - helps avoid duplication and potential confusion. Following this principle, I am pushing my changes to the Zeto repository instead of the Paladin repository.