Use Go version from go.mod in CI workflows #5155
Open
+19
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mark S. Lewis <[email protected]>
bestbeforetoday
commented
Feb 25, 2025
Comment on lines
-34
to
-36
| - name: Check Go module version | ||
| run: | | ||
| [[ "$(go list -m -f '{{.Version}}' go)" == "${GO_VER}" ]] |
There was a problem hiding this comment.
Check that the CI and go.mod versions match is no longer required since the CI uses the go.mod version.
bestbeforetoday
commented
Feb 25, 2025
Comment on lines
+98
to
+101
| - name: Set GO_VER environment variable from go.mod | ||
| run: | | ||
| awk '/^go[ /t]/ { gsub(/^go[ \t]+|[ \t]+^/, ""); print "GO_VER="$0; exit }' < go.mod >> "${GITHUB_ENV}" | ||
There was a problem hiding this comment.
Alternative approach would be to set up go using actions/setup-go and the go.mod file, then read the go-version output from that action.
There was a problem hiding this comment.
This approach looks good.
|
@denyeart Using the Go version from go.mod was easier than I thought since actions/setup-go provides a go-version-file input option. This change could use some additional eyes to see if I missed anything. And perhaps a trial of the release workflow since that uses some scripting magic. |
denyeart
approved these changes
Feb 25, 2025
Comment on lines
+98
to
+101
| - name: Set GO_VER environment variable from go.mod | ||
| run: | | ||
| awk '/^go[ /t]/ { gsub(/^go[ \t]+|[ \t]+^/, ""); print "GO_VER="$0; exit }' < go.mod >> "${GITHUB_ENV}" | ||
There was a problem hiding this comment.
This approach looks good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.