-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proto master merge #1
Open
pyramation
wants to merge
87
commits into
telescope
Choose a base branch
from
proto-master-merge
base: telescope
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [bl](https://github.com/rvagg/bl) from 1.2.2 to 1.2.3. - [Release notes](https://github.com/rvagg/bl/releases) - [Commits](rvagg/bl@v1.2.2...v1.2.3) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Renovate Bot <[email protected]> Co-authored-by: Alexander Fenster <[email protected]>
closes #1500 fixes #885 Co-authored-by: Benjamin E. Coe <[email protected]>
…#1234) * Get protobufjs-cli to a publishable state * Fix eslint issues * Fix pbts path * Install cli package deps on CI 'build' job * fix: get rid of require-protobufjs.js * fix: lint * fix: versions * chore(deps): update package-lock.json Co-authored-by: Stacey Sern <[email protected]> Co-authored-by: Gabriel Cangussu <[email protected]> Co-authored-by: Alexander Fenster <[email protected]>
parent README doesn't have documentation about pbjs and it is moved to cli's README, update the link to the correct one.
This option skips generation of service clients. Co-authored-by: Alexander Fenster <[email protected]>
* deps: set @types/node to star version When using `protobuf.js` as a dependency in a project it is important that `@types/node` package gets de-duped and has the same version as for the rest of the modules in the project. Otherwise, typing conflicts could happen as they do between v13 and v14 node types. * fix: use @types/node >=13.7.0 * fix: use @types/node >=13.7.0 Co-authored-by: Alexander Fenster <[email protected]> Co-authored-by: Alexander Fenster <[email protected]>
Co-authored-by: Benjamin E. Coe <[email protected]>
* test: adding test for pbjs static code generation * fix: fromObject should not initialize oneof members
… in parseOptionValue (#1571) * allow for an optional semicolon where there is an optional comma in parseOptionValue * set allowShortCircuit to true to prevent no-unused-expressions error * add test for semicolon Co-authored-by: Alexander Fenster <[email protected]>
accross -> across
…r field with trailing comment (#1593) Co-authored-by: Iaroslav Kolbin <[email protected]> Co-authored-by: Alexander Fenster <[email protected]>
* feat: add null-defaults option * fix: linting Co-authored-by: Alexander Fenster <[email protected]> Co-authored-by: Alexander Fenster <[email protected]>
Co-authored-by: Alexander Fenster <[email protected]>
* Add getTypeUrl method to static-module generated code * add tests for getTypeUrl method
* Patch minimatch vulnerability If I follow this, glob packages minimatch. Minimatch released a fix, glob also has a newer build, picking this up should pick up that. Fixes #1696 Fixes #1697 Fixes #1698 * chore: update lockfile Co-authored-by: Alexander Fenster <[email protected]>
* feat: prepare initial publication of cli * build: try to fix build * test: try to make node4 ci work * test: run all ci tasks at once * fix: bring package.json @types/node back Co-authored-by: Alexander Fenster <[email protected]>
According to https://docs.npmjs.com/cli/v8/configuring-npm/package-json#local-paths the local path should be `file:..` instead of `file://..`. The later version copies whole top-level file-system in a macOS and with a recent version of npm (8.12.2) and results in a `MODULE_NOT_FOUND` error. Co-authored-by: Alexander Fenster <[email protected]>
Co-authored-by: Alexander Fenster <[email protected]>
* feat: proto3 optional support * chore: pre-release v6.11.0-pre * fix: rebuild * fix: fromObject should not initialize oneof members (#1597) * test: adding test for pbjs static code generation * fix: fromObject should not initialize oneof members * chore: release v6.11.0 * chore: rebuild * feat: add --no-service option for pbjs static target (#1577) This option skips generation of service clients. Co-authored-by: Alexander Fenster <[email protected]> * deps: set @types/node to >= (#1575) * deps: set @types/node to star version When using `protobuf.js` as a dependency in a project it is important that `@types/node` package gets de-duped and has the same version as for the rest of the modules in the project. Otherwise, typing conflicts could happen as they do between v13 and v14 node types. * fix: use @types/node >=13.7.0 * fix: use @types/node >=13.7.0 Co-authored-by: Alexander Fenster <[email protected]> Co-authored-by: Alexander Fenster <[email protected]> * chore: rebuild * docs: update changelog * fix: parse.js "parent.add(oneof)“ error (#1602) Co-authored-by: xiaoweili <[email protected]> * chore: release v6.11.1 * fix(types): bring back Field.rule to .d.ts * fix: rebuild type, release v6.11.2 * build: configure backports * build: configure 6.x as default branch * fix: do not let setProperty change the prototype (#1731) * fix(deps): use eslint 8.x (#1728) * build: run tests if ci label added (#1734) * build: publish to main * chore(6.x): release 6.11.3 (#1737) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Support parsing of complex options * Use readValue to read the proto value and add better example * Fix lint issues * fix: rollback files * Re-do parse logic to take arrays into account and make it simpler Co-authored-by: Alexander Fenster <[email protected]> Co-authored-by: Matthew Douglass <[email protected]> Co-authored-by: Fedor Indutny <[email protected]> Co-authored-by: Alexander Fenster <[email protected]> Co-authored-by: leon <[email protected]> Co-authored-by: xiaoweili <[email protected]> Co-authored-by: Benjamin Coe <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* Update minimal.js See https://github.com/Agoric/agoric-sdk/blob/master/patches/%40confio%2Bics23%2B%2Bprotobufjs%2B6.11.3.patch The original code used assignment to override the `constructor` and `toString` properties inherited from Error.prototype. However, if `Error.prototype` is frozen, as it is under Hardened JS (aka SES) or under the Node frozen intrinsics flag, then this assignment fails due to the JavaScript "override mistake". `enumerable: true` would accurately preserve the behavior of the original assignment, but I'm guessing that was not intentional. For an actual error subclass, this property would not be enumerable, so my PR currently proposes that. But either would work, so let me know if you'd like me to change it. `configurable: false` would accurately preserve the behavior of the original, but I'm guessing that was not intentional. For an actual error subclass, this property would be configurable. But either would work, so let me know if you'd like me to change it. * chore: use ecmaVersion=6 for eslint Co-authored-by: Alexander Fenster <[email protected]>
* feat: allow message.getTypeUrl provide custom tyepUrlPrefix * Update static.js * test: added tests, regenerated test files Co-authored-by: Alexander Fenster <[email protected]>
Bumps [decode-uri-component](https://github.com/SamVerschueren/decode-uri-component) from 0.2.0 to 0.2.2. - [Release notes](https://github.com/SamVerschueren/decode-uri-component/releases) - [Commits](SamVerschueren/decode-uri-component@v0.2.0...v0.2.2) --- updated-dependencies: - dependency-name: decode-uri-component dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
… (#1840) * feat: add message filter for cli * feat: add test * fix: update comment * fix: update error message * fix: remove test file * fix: lint, jsdoc comments, return values Co-authored-by: pluschen <[email protected]> Co-authored-by: Alexander Fenster <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This reverts commit e7a3489.
* CLI: Fix relative path to Google pb files * Revert previous PR. * Use bundled filename when fetching proto file.
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…784) * do not allow to extend same field twice to prevent the error * Ignore gitpod config * unit test for issue #1783 * using existing test file
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* fix: do not let setProperty change the prototype * test: add unit test
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Filip Mösner <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* Add handling for extension range options * Fix CI failures * Fix more test issues
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* Fix the type of reserved field in IType * Fix the type issue in src file
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
# By Alexander Fenster (13) and others # Via Zetazzz * telescope: (31 commits) update version init letter stays the same publish config change the package name fix camel case util and add tests pkg right trim comments build maps telescope meta data chore(6.x): release 6.11.3 (#1737) build: publish to main build: run tests if ci label added (#1734) fix(deps): use eslint 8.x (#1728) fix: do not let setProperty change the prototype (#1731) build: configure 6.x as default branch build: configure backports fix: rebuild type, release v6.11.2 fix(types): bring back Field.rule to .d.ts chore: release v6.11.1 ... # Conflicts: # .github/workflows/release.yaml # CHANGELOG.md # cli/README.md # cli/package.json # cli/pbjs.js # cli/targets/static.js # dist/light/protobuf.js # dist/light/protobuf.js.map # dist/light/protobuf.min.js # dist/light/protobuf.min.js.map # dist/minimal/protobuf.js # dist/minimal/protobuf.min.js # dist/minimal/protobuf.min.js.map # dist/protobuf.js # dist/protobuf.js.map # dist/protobuf.min.js # dist/protobuf.min.js.map # package-lock.json # package.json # src/namespace.js # src/parse.js # src/tokenize.js # src/util.js # tests/cli.js # tests/comp_optional.js # tests/data/cli/test.proto
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.