Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: status bar icon brightness for iOS light mode #299

Merged
merged 1 commit into from
Sep 3, 2024
Merged

fix: status bar icon brightness for iOS light mode #299

merged 1 commit into from
Sep 3, 2024

Conversation

Zied-Dahmani
Copy link
Collaborator

Scope

Ticket

I set statusBarBrightness to Brightness.light for the iOS light theme to make the status bar icons dark.

Screenshots

Before After
before after

@Zied-Dahmani Zied-Dahmani requested a review from n13 September 2, 2024 15:22
@Zied-Dahmani Zied-Dahmani self-assigned this Sep 2, 2024
@Zied-Dahmani Zied-Dahmani linked an issue Sep 2, 2024 that may be closed by this pull request
Fix Status Bar Icon Brightness for iOS Light Mode #298
Closed
n13
n13 approved these changes Sep 3, 2024
View reviewed changes
Copy link
Collaborator

@n13 n13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh - very nice, thank you

@Zied-Dahmani Zied-Dahmani merged commit e3be92c into main Sep 3, 2024
0 of 3 checks passed
@Zied-Dahmani Zied-Dahmani deleted the bugfix/status-bar-icon-brightness branch September 3, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@n13 n13 n13 approved these changes

Assignees

@Zied-Dahmani Zied-Dahmani

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix Status Bar Icon Brightness for iOS Light Mode
2 participants
@Zied-Dahmani @n13