refactor: merge proposal details UI with business logic #307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n13
approved these changes
Sep 10, 2024
There was a problem hiding this comment.
Will need to run tests
Did you make tasks for the fix items you mentioned?
Note: The logic for displaying rewards for the cycle or period is not yet implemented (unclear at the moment).
Cycle = period_value x 4
Note: The utility token is currently shown as the cash token, and the cash token is shown as the utility token.
Please fix or create fix task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope
Ticket
I have
mergedthe proposal detailsUIwith thebusiness logic.Note:The logic for displaying rewards for the cycle or period is not yet implemented (unclear at the moment).Note:Addressed issue with invalid image (S3).