Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefer system VDPAU headers if present #71

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

turboencabulator
Copy link
Contributor

In case they happen to be different from the bundled ones.

Also move the REQUIRED argument before the module spec to match the
documented usage for pkg_check_modules.
@i-rinat
Copy link
Owner

i-rinat commented May 26, 2022

I don't think this is a good idea. I can't see this change helping/fixing/simplifying anything, but at the same time it may cause issues. In fact this approach did cause issues before.

Initially, I used VDPAU headers from libvdpau-dev, and it was fine. But at some moment I've found that mpv tried to use Constrained Baseline profile of H.264 (#50 (comment)). Any hardware that supports higher profiles automatically supports Baseline and Constrained Baseline. It's just libvdpau-va-gl wasn't checking VDP_DECODER_PROFILE_H264_CONSTRAINED_BASELINE. The fix is trivial, but it caused compilation failures on machines with older versions of libvdpau-dev: #55.

Workaround may be possible, but I did not manage to come up with one that would work with all versions of VDPAU headers. So the only solution left was to use a specific version of headers. There should be no issues with older code on newer systems, since VDPAU extends its structures by appending members and never rearranging older ones.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants