fix unnecessary parentheses for binary operators and add regression test

iBelieve · Feb 6, 2020 · 90f59c2 · 90f59c2
1 parent 86d0006
commit 90f59c2
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 1 deletion.
diff --git a/escodegen.js b/escodegen.js
@@ -1835,7 +1835,7 @@
         BinaryExpression: function (expr, precedence, flags) {
             var result, leftPrecedence, rightPrecedence, currentPrecedence, fragment, leftSource;
             currentPrecedence = BinaryPrecedence[expr.operator];
-            leftPrecedence = expr.operator === '**' ? Precedence.Postfix : currentPrecedence + 1;
+            leftPrecedence = expr.operator === '**' ? Precedence.Postfix : currentPrecedence;
             rightPrecedence = expr.operator === '**' ? currentPrecedence : currentPrecedence + 1;
 
             if (currentPrecedence < precedence) {

diff --git a/test/compare/binary-precedence.expected.js b/test/compare/binary-precedence.expected.js
@@ -0,0 +1,4 @@
+a + b + c;
+a + (b + c);
+a + b * c;
+a * b + c;
diff --git a/test/compare/binary-precedence.js b/test/compare/binary-precedence.js
@@ -0,0 +1,4 @@
+(a + b) + c;
+a + (b + c);
+a + b * c;
+a * b + c;