Introduce the DateFmtInfo object. #202
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the idea of a value property, the value of which is a function that calculates the value of this field based on the value of other fields. For example, the day of week is not something that a UI typically displays in a date input form. Instead, you pick the year, month, and day and the day of week is determined automatically. More work is needed for time zones and to translate stuff.
Add the idea of a value property, the value of which is a function that calculates the value of this field based on the value of other fields. For example, the day of week is not something that a UI typically displays in a date input form. Instead, you pick the year, month, and day and the day of week is determined automatically. More work is needed for time zones and to translate stuff.
(They don't pass though.)
- use "placeholder" instead of "template" property - use an options param instead of separate params to the getFormatInfo
Also updated the jsdocs to reflect the options param.
Things don't work yet...
Generated from the cldr 34 data.
Gleaned from the names of the field. For Arabic script or RTL languages or short names, just use the full name. For everything else, use abbreviations.
Much more work needed
Still need to fix more though
solved more unit test failures, but also added more unit tests.
The tests were not testing async properly. Now they are.
- after effects of a less-than-successful merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOT READY TO MERGE YET.
Gives information about the date format without cluttering up the methods on the date format object itself. The methods on the date format object are now deprecated and will be removed in ilib 16.X
Checklist
ReleaseNoteshas added or is not needed.NodejsandChrome Browser.QT/QML.Issue Resolved / Feature Added
Resolution
Links