Little code updates

iMattPro · Sep 4, 2021 · 2d5dfe6 · 2d5dfe6
1 parent dc490a6
commit 2d5dfe6
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 5 deletions.
diff --git a/adm/style/acp_abbc3_settings.html b/adm/style/acp_abbc3_settings.html
@@ -60,9 +60,9 @@
 	const select = document.querySelector("select[name='abbc3_icons_type']");
 	document.querySelector(".abbc3-icons-" + select.value).classList.toggle("hidden");
 	select.addEventListener("change", () => {
-		document.querySelectorAll(".abbc3-bar").forEach(bar => {
+		for (const bar of document.querySelectorAll(".abbc3-bar")) {
 			bar.classList.toggle("hidden");
-		});
+		}
 	});
 </script>
 

diff --git a/core/acp_manager.php b/core/acp_manager.php
@@ -223,7 +223,7 @@ public function resynchronize_bbcode_order()
 		$order = 0;
 		while ($row = $this->db->sql_fetchrow($result))
 		{
-			if (++$order != $row['bbcode_order'])
+			if (++$order !== (int) $row['bbcode_order'])
 			{
 				$this->db->sql_query($this->update_bbcode_order($row['bbcode_id'], $order));
 			}

diff --git a/core/bbcodes_display.php b/core/bbcodes_display.php
@@ -81,7 +81,7 @@ public function display_custom_bbcodes($custom_tags, $row)
 		$icon_tag = strtolower(rtrim($row['bbcode_tag'], '='));
 
 		$custom_tags['BBCODE_IMG'] = isset($icons[$icon_tag]) ? $icons[$icon_tag] : '';
-		$custom_tags['S_CUSTOM_BBCODE_ALLOWED'] = !empty($row['bbcode_group']) ? $this->user_in_bbcode_group($row['bbcode_group']) : true;
+		$custom_tags['S_CUSTOM_BBCODE_ALLOWED'] = empty($row['bbcode_group']) || $this->user_in_bbcode_group($row['bbcode_group']);
 
 		return $custom_tags;
 	}

diff --git a/core/bbcodes_installer.php b/core/bbcodes_installer.php
@@ -171,7 +171,7 @@ protected function get_max_bbcode_id()
 	 *
 	 * @param string $bbcode_name Name of bbcode
 	 * @param string $bbcode_tag  Tag name of bbcode
-	 * @return mixed Existing bbcode data array or false if not found
+	 * @return array|false Existing bbcode data array or false if not found
 	 * @access protected
 	 */
 	public function bbcode_exists($bbcode_name, $bbcode_tag)