Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Runr full implementation draft #62

Merged
merged 28 commits into from
Oct 4, 2024
Merged

Runr full implementation draft #62

merged 28 commits into from
Oct 4, 2024

Conversation

federicomarini
Copy link
Contributor

Keeping this as a draft as long as we are not happy with the final status

@federicomarini
exposing the app title as parameter to be possibly chosen by the user…
969796f 
… upon launching iSEEindex()
@federicomarini
updting GHA workflow to run with Bioc 3.19 in devel
36aa8a7
@federicomarini
adding the example files used to go with the TonsilDataAtlas package
bb3769e
@federicomarini
updated roxygen note
683976e
@federicomarini
adding "parallel" implementation for having the runr modality impleme…
bce3c83 
…nted
@federicomarini
re-rendering manpage
66a53ee
@federicomarini
Merge branch 'devel' into runr_full_implementation_draft
e2df998 
# Conflicts:
#	DESCRIPTION
#	R/iSEEindex.R
#	man/iSEEindex-pkg.Rd
@federicomarini
Merge remote-tracking branch 'origin' into runr_full_implementation_d…
9739daa 
…raft
@federicomarini
adapting the example for the runr functionality to reflect the new lo…
0944a11 
…cation in the inst folder
@federicomarini
generating some first set of content for the iSEEindexRunrResource cl…
373b2ca 
…ass documentation
@federicomarini
yolo'ing the sets of changes done to have the runr up n running - so …
193d0b6 
…far uses a propagation of a parameter
@federicomarini
going in with a simple heuristics to determine what should happen on …
dab973b 
…the resource passed.

path -> prefetch fully and load
object -> just load
Might be thinking of extra work to have an extra field in the resource class to define this more flexibly, but so far so good?
@federicomarini
param already_se_object is not required anymore, replaced by the he…
7aecda4 
…uristics
@federicomarini
adding another yaml, "just for the fun" and for showing a proof of pr…
ff5eb34 
…inciple that this could simply work
@federicomarini
general cleanup, and polishing a bit what is there so far
08cd8fe
@federicomarini
expanding the test suite to cover the runr usage
cc9b964
@federicomarini
Some general information on the runr implementation is provided also …
34080f9 
…in the vignette
@federicomarini
Merge pull request #63 from iSEE/runr_flexible_handling
247814e 
Runr flexible handling of the behavior for the different resource classes
@federicomarini
Merge pull request #64 from iSEE/runr_backpropagated_param
bd12c92 
Runr full implementation
@federicomarini federicomarini marked this pull request as ready for review October 2, 2024 22:55
@federicomarini federicomarini merged commit 3ba3982 into devel Oct 4, 2024
4 of 6 checks passed
@federicomarini federicomarini mentioned this pull request Oct 4, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@federicomarini