Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(RasterTile): partial loading for raster tiles #2489

Merged
merged 2 commits into from
Feb 24, 2025

Conversation

airnez
Copy link
Contributor

@airnez airnez commented Jan 22, 2025

Description

Sets a new way to request data from DataSource provider : partial loading. If it is enabled, the command execution is considered successful as soon as one of the data loading promise is successful. It returns the same results array than before but includes null for failed requests. The caller takes responsibility for handling those null values.

Motivation and Context

See issue 2311. It more broadly fixes glitches whitnessed when rendering reprojected raster (or ratserized) data sources . It especially occurres from far away or on data source boundaries, when projecting (epsg:3857) data on the globe (epsg:4326). This seems to correspond to issue 2395

Screenshots

See before / after comparison for this layer :

            var wmtsSource = new itowns.WMTSSource({
                url: 'https://data.geopf.fr/wmts?SERVICE=WMTS&VERSION=1.0.0&REQUEST=GetCapabilities',
                crs: 'EPSG:3857',
                name: 'GEOGRAPHICALGRIDSYSTEMS.EDUGEO.LYON1947',
                tileMatrixSet: 'PM_6_16',
                version: '1.0.0',
                style: 'normal',
                format: 'image/png',
            });

Before fix

partial-loading-bug.mp4

After fix

partial-loading-fix.mp4

@jailln jailln requested a review from Desplandis January 23, 2025 08:07
@airnez airnez changed the title fix(RasterTile): partial loading for raster tiles [DRAFT] fix(RasterTile): partial loading for raster tiles Jan 27, 2025
@airnez airnez force-pushed the fix/partial-loading branch 2 times, most recently from 5c89240 to 8122634 Compare February 4, 2025 13:50
@airnez airnez changed the title [DRAFT] fix(RasterTile): partial loading for raster tiles fix(RasterTile): partial loading for raster tiles Feb 4, 2025
@airnez airnez marked this pull request as ready for review February 4, 2025 14:46
@airnez airnez force-pushed the fix/partial-loading branch from 630bae9 to 2e136c8 Compare February 4, 2025 14:48
@airnez airnez requested review from Desplandis and removed request for Desplandis February 4, 2025 15:12
Copy link
Contributor

@Desplandis Desplandis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@Desplandis Desplandis mentioned this pull request Feb 17, 2025
@airnez airnez force-pushed the fix/partial-loading branch from 2e136c8 to 9c6ac4b Compare February 24, 2025 08:43
@airnez airnez merged commit b395a75 into iTowns:master Feb 24, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants