Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump 3d tiles renderer to 0.4.4 and three.js to 0.170.0 #2496

Merged
merged 3 commits into from
Feb 7, 2025

Conversation

Desplandis
Copy link
Contributor

@Desplandis Desplandis commented Feb 6, 2025

Description

This PR bumps 3d-tiles-renderer from 0.3.39 to 0.4.4 and three.js from 0.168.0 to 0.170.0.

Changes in three

r169

See changelog and migration guide.

There is no changes impacting iTowns.

A list of interesting changes (feel free to extend it):

r170

See changelog and migration guide.

A list of interesting changes (feel free to extend it):

Changes in 3d-tiles-renderer

There is some changes impacting iTowns, especially for plugins. I disabled some eslint check on imports since it does not support package.json imports... (see import-js/eslint-plugin-import#1868). It seems eslint-import-resolver-typescript works but decided to go for disabling this warning for now.

Added

  • load-error events when model, tile set, and API token requests fail to fetch or parse. To use internally in iTowns and provide a way to the user to access this event.
  • PNTSLoader: Add support for normals, quantized normals.
  • TilesRenderer: Support for 3DTILES_ELLIPSOID extension.
  • TilesRenderer: added "loadProgress" field.
  • BatchedMeshPlugin plugin: Plugin: BatchedMeshPlugin NASA-AMMOS/3DTilesRendererJS#628. I think we should examine the performance gains in using BatchedMesh for 3D Tiles rendering.

@Desplandis Desplandis force-pushed the bump/3d-tiles-renderer-0.44 branch 2 times, most recently from f2d0476 to 79fbc90 Compare February 6, 2025 10:35
@Desplandis Desplandis marked this pull request as ready for review February 6, 2025 10:46
@Desplandis Desplandis requested a review from jailln February 6, 2025 10:46
@Desplandis Desplandis force-pushed the bump/3d-tiles-renderer-0.44 branch from 79fbc90 to 6fc3917 Compare February 6, 2025 10:53
@jailln jailln requested review from AnthonyGlt and removed request for jailln February 6, 2025 13:32
@AnthonyGlt
Copy link
Contributor

There is a breaking change for the WEBXR example, probably this one
#2473

BUT I'm currently working on a refactoring of the webxr.

Should we put it in deprecated for now ?

@Desplandis
Copy link
Contributor Author

@AnthonyGlt Depends on whether or not we considered the WebXR example as ready to production or not.

@AnthonyGlt
Copy link
Contributor

AnthonyGlt commented Feb 7, 2025

There is already a webxr example available (view_3d_map_webxr) , I'm just saying that with this bump, it wouldn't work anymore.
For now, we should, at least, remove the access to this example from the config.json, until incoming refactoring. I don't think that we should hot fix it because of this refactoring.
IF we rather hot fix it, I've gave a solution in the issue mentioned above.
WDYT ?

Either way, some changes should be made in this file
to fix it or to link to the issue, so users will know that it's temporarily broken and how to bypass the bug

@Desplandis Desplandis force-pushed the bump/3d-tiles-renderer-0.44 branch from 6fc3917 to da403b8 Compare February 7, 2025 11:34
@Desplandis
Copy link
Contributor Author

Okay, I added the quickfix in the example as suggested in your issue, that should be good enough. =)

@Desplandis Desplandis merged commit e75fbb8 into iTowns:master Feb 7, 2025
9 checks passed
@Desplandis Desplandis deleted the bump/3d-tiles-renderer-0.44 branch February 7, 2025 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants