perf: apply memory optimizations to TokenReader
#27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These optimizations are analogous to those made in #26 for `Scanner`. The performance improvement for `Reader` is less significant, but still noticeable: ``` Benchmark 1 (48 runs): zig-out/bin-old/reader Gtk-4.0.gir measurement mean ± σ min … max outliers delta wall_time 106ms ± 1.72ms 104ms … 110ms 0 ( 0%) 0% peak_rss 7.28MB ± 80.9KB 7.08MB … 7.34MB 0 ( 0%) 0% cpu_cycles 420M ± 6.94M 413M … 438M 0 ( 0%) 0% instructions 1.13G ± 19.3 1.13G … 1.13G 0 ( 0%) 0% cache_references 561K ± 72.6K 477K … 878K 2 ( 4%) 0% cache_misses 12.7K ± 1.31K 11.3K … 18.3K 3 ( 6%) 0% branch_misses 1.07M ± 5.21K 1.07M … 1.09M 0 ( 0%) 0% Benchmark 2 (50 runs): zig-out/bin/reader Gtk-4.0.gir measurement mean ± σ min … max outliers delta wall_time 101ms ± 1.08ms 98.9ms … 103ms 1 ( 2%) ⚡- 4.9% ± 0.5% peak_rss 7.29MB ± 63.6KB 7.21MB … 7.34MB 0 ( 0%) + 0.2% ± 0.4% cpu_cycles 398M ± 4.24M 393M … 410M 1 ( 2%) ⚡- 5.2% ± 0.5% instructions 1.11G ± 20.8 1.11G … 1.11G 0 ( 0%) ⚡- 1.5% ± 0.0% cache_references 404K ± 244K 314K … 1.82M 4 ( 8%) ⚡- 28.0% ± 13.0% cache_misses 12.0K ± 1.11K 10.1K … 15.3K 0 ( 0%) ⚡- 5.6% ± 3.8% branch_misses 1.10M ± 2.89K 1.10M … 1.12M 4 ( 8%) 💩+ 2.8% ± 0.2% ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These optimizations are analogous to those made in #26 for
Scanner. The performance improvement forReaderis less significant, but still noticeable: