feat: reader memory reuse improvements #32
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #30 This currently provides no benefit in itself based on my benchmarks, but opens the door to further performance opportunities for `Reader`. Since `TokenReader`'s buffer is now allowed to grow, it is no longer necessary for the decoder interface to handle overflowing the encoding buffer. As such, the parameter type of the buffer has been changed to reflect the exact necessary size, and `error.Overflow` is no longer returned. BREAKING CHANGE: `TokenReader` now requires an allocator, and `error.Overflow` is no longer returned from any reader function.
|
Superseded by #36. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The intention is for this PR to address both #30 and #31 so some real benefits can be realized. Just implementing #30 by itself without any meaningful change to
Readerto take advantage of the increased flexibility provides no benefit.