Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add start for ESO archive #18

Closed
wants to merge 6 commits into from
Closed

Add start for ESO archive #18

wants to merge 6 commits into from

Conversation

DanielAndreasen
Copy link
Collaborator

This is related to issue #1. Definitely not done, but a start. Some suggestions are welcome. Documentations for this can be found here

@jason-neal
Copy link
Collaborator

I was thinking...
I might be an idea to make the username just a keyword. So you don't need to specify it when just searching for data.

I know argparse has mutually exclusive flags but I am not sure about mutually inclusive.
You could make it so you only need to pass username when actually need to login.
e.g. username require when you want to --download the files.

python eso_archive.py --object Aldebaran --download --username xxxxx 
python eso_archive.py --object Aldebaran --download 
Warning: You need to supply a username to download data from the eso archive.

What do you think?

@DanielAndreasen
Copy link
Collaborator Author

I think it's a solid suggestion. Let me have a look

@jason-neal
Copy link
Collaborator

jason-neal commented May 10, 2017

Also following the astroquery.eso docs you can have automatic login setup with astropy.config.

So maybe the mutually inclusive is constraint is not a good idea, in case you want to have it stored automatically.

Just have it as a keyword.

@coveralls
Copy link

coveralls commented May 14, 2017

Coverage Status

Changes Unknown when pulling d324787 on eso_archive into ** on master**.

@DanielAndreasen
Copy link
Collaborator Author

Seems like this project is dead, and I want to clear out my open PRs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants