Use DI to replace validator service used in symfony validator #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…validator service instance in-place ("new")
jkobus
force-pushed
the
service-replacement-for-symfony-validator
branch
from
cee5ae1 to
1c79eac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem:
VatNumberValidator uses "new" instead of autowiring, therefore I'm unable to replace service with different Vies Client (rest).
This change will make this possible.
Please review it and let me know if it needs adjustments.
I also added intl and soap extensions as after
composer installthese are actually required during development.I tested the dev branch in my app and can confirm it works as expected.