Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ibx 8316 temp #1481

Draft
wants to merge 3 commits into
base: 4.6
Choose a base branch
from
Draft

Ibx 8316 temp #1481

wants to merge 3 commits into from

Conversation

GrabowskiM
Copy link
Contributor

@GrabowskiM GrabowskiM commented Feb 26, 2025

🎫 Issue IBX-XXXXX

Description:

Potentially different approach than #1465
Previous one was calling events for each element separately, this one does it in one modal event. Current approach I think is more bug-proof, as having multiple event listeners could cause in future that there will be delay between adjusting nodes, depending on how quick events are executed.

It's drawback is that it in some way duplicates controlZIndex in terms of adding events and dispatching it. But as this one allows array, setting specific zIndex and having different modal event listener adjusting old helper made it so much less clean (1465 looks really bad imo, compared to this one)

Usage, sth like that:

        storedControlZIndex = betterControlZIndex(
            [
                {
                    container: fieldsConfigPanel,
                    zIndex: 1,
                },
                {
                    container: fieldsConfigPanelTogglerBtn,
                },
            ],
            doc,
        );

For QA:

Documentation:

@GrabowskiM GrabowskiM marked this pull request as draft February 26, 2025 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants