Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pagination to dashboard list views #23

Merged
merged 6 commits into from
Oct 12, 2020
Merged

Add pagination to dashboard list views #23

merged 6 commits into from
Oct 12, 2020

Conversation

landonreed
Copy link
Contributor

@landonreed landonreed commented Sep 10, 2020 •
edited
Loading

This adds pagination to otp-admin-ui lists. It also simplifies some of the messages (removes the latest fetch update and message about auto-refresh) to make room for these new controls.

It depends on changes in otp-middleware: ibi-group/otp-middleware#72

@vercel
Copy link

vercel bot commented Sep 10, 2020 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/ibi-group/otp-admin-ui/p7cnkayth
✅ Preview: https://otp-admin-ui-git-add-pagination.ibi-group.vercel.app

@landonreed landonreed self-assigned this Sep 10, 2020
@landonreed landonreed mentioned this pull request Sep 10, 2020
Merged
5 tasks
@landonreed landonreed marked this pull request as ready for review September 29, 2020 20:29
evansiroky
evansiroky approved these changes Sep 30, 2020
View reviewed changes
Copy link
Contributor

@evansiroky evansiroky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just 2 non-blocking comments.

@evansiroky evansiroky assigned landonreed and unassigned evansiroky Sep 30, 2020
@landonreed landonreed removed their assignment Sep 30, 2020
binh-dam-ibigroup
binh-dam-ibigroup requested changes Oct 1, 2020
View reviewed changes
Copy link
Contributor

@binh-dam-ibigroup binh-dam-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace <h5> with <div>, make sure LayoutWithAuth0 can parse the result of secureFetch, and other cosmetic comments.

components/PageControls.js Show resolved Hide resolved
components/PageControls.js Show resolved Hide resolved
components/ErrorEventsDashboard.js Outdated Show resolved Hide resolved
components/ErrorEventsDashboard.js Outdated Show resolved Hide resolved
components/ErrorEventsDashboard.js Outdated Show resolved Hide resolved
components/RequestLogsDashboard.js Outdated Show resolved Hide resolved
util/middleware.js Show resolved Hide resolved
binh-dam-ibigroup
binh-dam-ibigroup approved these changes Oct 7, 2020
View reviewed changes
Copy link
Contributor

@binh-dam-ibigroup binh-dam-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now. Thanks for the changes.

@binh-dam-ibigroup
Copy link
Contributor

I'm blocking this PR pending resolution of ibi-group/otp-middleware#72.

@landonreed
Copy link
Contributor Author

Merging now that ibi-group/otp-middleware#72 is merged.

@landonreed landonreed merged commit 36705cb into dev Oct 12, 2020
@landonreed landonreed deleted the add-pagination branch October 12, 2020 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evansiroky evansiroky evansiroky approved these changes

@binh-dam-ibigroup binh-dam-ibigroup binh-dam-ibigroup approved these changes

Assignees

@landonreed landonreed

Labels
BLOCKED
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@landonreed @binh-dam-ibigroup @evansiroky