Localized trip times in notifications #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…using the user's locale.
…ip notifications.
AdrianaCeric
approved these changes
Dec 18, 2023
| Arguments.of("es", "17:44"), | ||
| Arguments.of("ko", "오후 5:44"), | ||
| Arguments.of("vi", "17:44"), | ||
| Arguments.of("zh", "下午5:44"), // Note: formatjs shows 24-hour format for Chinese. |
There was a problem hiding this comment.
Suggested change
| Arguments.of("zh", "下午5:44"), // Note: formatjs shows 24-hour format for Chinese. | |
| Arguments.of("zh", "下午5:44"), // Note: format.js shows 24-hour format for Chinese. |
There was a problem hiding this comment.
Should actually be "FormatJS".
There was a problem hiding this comment.
Heck, idk. They have all three spellings on a single page - header, intro paragraph, and copyright: https://formatjs.io/docs/getting-started/installation
There was a problem hiding this comment.
"Format.JS" it is (6d0b495)
br648
approved these changes
Dec 20, 2023
| @@ -41,9 +43,6 @@ private DateTimeUtils() { | |||
| public static final DateTimeFormatter DEFAULT_DATE_FORMATTER = DateTimeFormatter.ofPattern( | |||
| DEFAULT_DATE_FORMAT_PATTERN | |||
| ); | |||
| public static final DateTimeFormatter NOTIFICATION_TIME_FORMATTER = DateTimeFormatter.ofPattern( | |||
| ConfigUtils.getConfigPropertyAsText("NOTIFICATION_TIME_FORMAT", "HH:mm") | |||
There was a problem hiding this comment.
Can "NOTIFICATION_TIME_FORMAT" now be removed from env.yml.tmp, env.schema.json and README.md? It doesn't appear to be used anywhere else.
There was a problem hiding this comment.
Removed in 8811f9f, thanks for reminding me of these places!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
devbefore they can be merged tomaster)Description
This PR fixes the initial reminder to use the itinerary start time (and not
trip.tripTime)and updates trip notification contents with localized times (e.g. "5:44 PM" vs. "17:44").
There are no other changes to trip notification contents.