Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(NotificationUtils): Encode user email to retrieve push devices. #202

Merged
merged 2 commits into from
Dec 20, 2023
Merged

fix(NotificationUtils): Encode user email to retrieve push devices. #202

merged 2 commits into from
Dec 20, 2023

Conversation

binh-dam-ibigroup
Copy link
Collaborator

@binh-dam-ibigroup binh-dam-ibigroup commented Dec 19, 2023 •
edited
Loading

Checklist

  • Appropriate branch selected (all PRs must first be merged to dev before they can be merged to master)
  • Any modified or new methods or classes have helpful JavaDoc and code is thoroughly commented
  • The description lists all applicable issues this PR seeks to resolve
  • [na] The description lists any configuration setting(s) that differ from the default settings
  • All tests and CI builds passing

Description

Changes from this PR include correctly encoding a user's email address before retrieving the number of push devices.

br648
br648 approved these changes Dec 20, 2023
View reviewed changes
Copy link
Contributor

@br648 br648 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/main/java/org/opentripplanner/middleware/utils/NotificationUtils.java Outdated
@@ -327,7 +329,7 @@ public static int getPushInfo(String toUser) {
try {
Map<String, String> headers = Map.of("Accept", "application/json");
var httpResponse = HttpUtils.httpRequestRawResponse(
URI.create(PUSH_API_URL + "/devices/get?api_key=" + PUSH_API_KEY + "&user=" + toUser),
URI.create(getPushDevicesUrl(PUSH_API_URL + "/devices/get?api_key=" + PUSH_API_KEY + "&user=", toUser)),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit. This might now benefit from a String.format?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea, done in 0e8ba24.

@br648 br648 assigned binh-dam-ibigroup and unassigned br648 Dec 20, 2023
miles-grant-ibigroup
miles-grant-ibigroup approved these changes Dec 20, 2023
View reviewed changes
Copy link
Contributor

@miles-grant-ibigroup miles-grant-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't test this but code looks good!

@binh-dam-ibigroup binh-dam-ibigroup merged commit 86a6ef1 into dev Dec 20, 2023
2 checks passed
@binh-dam-ibigroup binh-dam-ibigroup deleted the encode-push-req-params branch December 20, 2023 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@br648 br648 br648 approved these changes

@miles-grant-ibigroup miles-grant-ibigroup miles-grant-ibigroup approved these changes

Assignees

@binh-dam-ibigroup binh-dam-ibigroup

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@binh-dam-ibigroup @br648 @miles-grant-ibigroup