Skip to content

Commit

Permalink
ci: temporarily add pure-sasl to impala conda dependencies
Browse files Browse the repository at this point in the history
  • Loading branch information
cpcloud committed Sep 18, 2021
1 parent b7959ec commit 4439ea7
Show file tree
Hide file tree
Showing 3 changed files with 17 additions and 3 deletions.
2 changes: 2 additions & 0 deletions ci/deps/impala.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,3 +6,5 @@ dependencies:
- thrift_sasl
- python-hdfs
- boost
# TODO:remove when https://github.com/conda-forge/impyla-feedstock/pull/28 lands
- pure-sasl
4 changes: 2 additions & 2 deletions ci/merge_and_update_env.sh
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@ if [ "$#" -eq 0 ]; then
exit 1
fi

# install conda-merge
mamba install --name ibis conda-merge
# install conda-merge, don't try to update already installed dependencies
mamba install --freeze-installed --name ibis conda-merge

additional_env_files=()

Expand Down
14 changes: 13 additions & 1 deletion ibis/backends/impala/tests/test_client.py
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,19 @@ def test_kerberos_deps_installed(env, test_data_db):
# errors and occur, because there is no kerberos server in
# the CI pipeline, but they imply our imports have succeeded.
# See: https://github.com/ibis-project/ibis/issues/2342
with pytest.raises((AttributeError, TTransportException)):
excs = (AttributeError, TTransportException)
try:
# TLDR: puresasl is using kerberos, and not pykerberos
#
# see https://github.com/requests/requests-kerberos/issues/63
# for why both libraries exist
from kerberos import GSSError
except ImportError:
pass
else:
excs += (GSSError,)

with pytest.raises(excs):
ibis.impala.connect(
host=env.impala_host,
database=test_data_db,
Expand Down

0 comments on commit 4439ea7

Please sign in to comment.