perf: cache entry points #10889
Merged
perf: cache entry points #10889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this change, running `pytest --collect-only --doctest-modules --full-trace` on https://github.com/NickCrews/mismo takes 2.76s. With this change, it takes 1.21s This is because every time pytest visits a module during test collection, it has to determine if each object inside the module is a test. During that process, it calls https://github.com/pytest-dev/pytest/blob/77f2c63a542fc9511f5919ddf7f4b64d237fda07/src/_pytest/python.py#L343, on every item. If I have a module where I do `import ibis`, then this means that we attempt to do `ibis.__test__`, which triggers the `__getattr__` function in `ibis/__init__.py`, which then goes out and loads the entry points. Turns out this is a slow process.
cpcloud
force-pushed
the
perf-cache-entrypoints
branch
from
23264f1 to
5d59a1d
Compare
cpcloud
approved these changes
Feb 24, 2025
cpcloud
added a commit
to cpcloud/ibis
that referenced
this pull request
Feb 25, 2025
This reverts commit 62e9bca.
cpcloud
added a commit
to cpcloud/ibis
that referenced
this pull request
Feb 25, 2025
This reverts commit 62e9bca.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a sibling to #10888
Without this change, running
pytest --collect-only --doctest-modules --full-traceon https://github.com/NickCrews/mismo takes 2.76s. With this change, it takes 1.21sThis is because every time pytest visits a module during test collection, it has to determine if each object inside the module is a test. During that process, it calls https://github.com/pytest-dev/pytest/blob/77f2c63a542fc9511f5919ddf7f4b64d237fda07/src/_pytest/python.py#L343, on every item. If I have a module where I do
import ibis, then this means that we attempt to doibis.__test__, which triggers the__getattr__function inibis/__init__.py, which then goes out and loads the entry points. Turns out this is a slow process for packages with many such modules (mismo has ~100 such modules).