Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bigquery): ensure that count distinct can be used in window functions without a specified window #10911

Merged

Conversation

cpcloud
Copy link
Member

@cpcloud cpcloud commented Feb 27, 2025

Allow bigquery count distinct in window functions if window is the whole table. Closes #10390.

@github-actions github-actions bot added tests Issues or PRs related to tests bigquery The BigQuery backend sql Backends that generate SQL labels Feb 27, 2025
@cpcloud
Copy link
Member Author

cpcloud commented Feb 27, 2025

BigQuery passing after this change:

cloud in 🌐 falcon in …/ibis on  fix-bigquery-count-distinct-windows is 📦 v10.1.0 via 🐍 v3.12.9 via ❄️  impure (ibis-3.12-env) took 20s
❯ pytest -m bigquery -n auto --dist loadgroup --snapshot-update -q
bringing up nodes...
..sssssssssssssssssssss....x.....xxx....x......x.......x...........x...........x.x..........x......................................................x............x......x........x.......................x...x.x..xxx.............xxxxxxxxxxxxx.xx.xxxx.xxx.xxsssssssssssssssssssssssssssssssssssssssssxsss.sssssssssssssssssssssssssssssssssssssss.xsxsssssssssssssssx.x.xxxxxxxxxxxxxxxx. [ 16%]
xx.x.xxxxxxxxxxxxxxxxxx.xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx.xxxxxxxxxxxxxxxxxx...x..x.....x.xxxx.x.x....x....x.........x...........x....x.x.x.xx.xx.xxx...x....xx..x..x....x...........x.........x...........x..xx........x..x.xxx...xxxx.xx...x.......x....xx..x......x........xx..............x..x.xx.x.........x..x....x.....x...x.xxx.x.......x............x...x....x.x............xx..... [ 33%]
...........x..........................x......x.xx.......x...xx..x..xxx.....xx.xxxx.xxx...x....x...x....x.x.x..x....xx.........x.....xxx........x..x...x.x..............x.........x....xx.....x..x...x.......x..........X.x.Xx......x...............XXx........................x..........x................x.x............................................................................. [ 49%]
.x.x.......x..........x.......x.......x..........................s........x...xx....xx..xx..x.xx.xxxx.x.x...x.xx....xx....x....x.....x..x.x...x.xx.........x......xx..xx................s......x........s....sx..s.................x.....x...x.....x............x.............x.x.x.....x.x.....x...........x.x.................x....x.xx................x......x..x...................... [ 66%]
.....................x.x....x....x......x....x.....x............x.............xx.....x..............................s..........s...............s.....................................x.......x........x......xxxxxxxxxxx................................x...........x....x.....................................s.............s....s.........s............................................. [ 82%]
.........x.......xx.................................................................................................................................................x..................................................................................................................................................................................................................... [ 99%]
...........                                                                                                                                                                                                                                                                                                                                                                                [100%]
1785 passed, 132 skipped, 358 xfailed, 4 xpassed in 306.31s (0:05:06)

@cpcloud cpcloud merged commit c9120e1 into ibis-project:main Feb 27, 2025
87 of 89 checks passed
@cpcloud cpcloud deleted the fix-bigquery-count-distinct-windows branch February 27, 2025 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bigquery The BigQuery backend sql Backends that generate SQL tests Issues or PRs related to tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: window functions not working as expected in BigQuery backend
1 participant