Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(athena): use a different database for each python version to avoid clobbering data #10930

Merged
merged 2 commits into from
Mar 3, 2025

Conversation

cpcloud
Copy link
Member

@cpcloud cpcloud commented Mar 3, 2025

Ensure that Athena test runs do not clobber each other by creating a database per user+python-version pair.

@cpcloud cpcloud force-pushed the athena-ci-namespaces branch from fd0bce8 to 72a2f1c Compare March 3, 2025 15:51
@github-actions github-actions bot added tests Issues or PRs related to tests athena The Amazon Athena backend labels Mar 3, 2025
@cpcloud cpcloud removed the tests Issues or PRs related to tests label Mar 3, 2025
@github-actions github-actions bot added the tests Issues or PRs related to tests label Mar 3, 2025
@cpcloud cpcloud force-pushed the athena-ci-namespaces branch from 72a2f1c to e94a48e Compare March 3, 2025 16:10
@cpcloud cpcloud added bug Incorrect behavior inside of ibis ddl Issues related to creating or altering data definitions ci Continuous Integration issues or PRs labels Mar 3, 2025
@cpcloud
Copy link
Member Author

cpcloud commented Mar 3, 2025

Athena is passing:

cloud in 🌐 falcon in …/ibis on  athena-ci-namespaces is 📦 v10.1.0 via 🐍 v3.12.9 via ❄️  impure (ibis-3.12-env) took 33s
❯ pytest -m athena -n auto --snapshot-update -q --maxfail=5
bringing up nodes...
s...........x..x..x.x..xx............xxxxxxxxxx..............x.........................x.........x........x.x.x........x..x.......x......s.......x..x.......xxxxxxxxxx..x..xx.......x....x.... [  9%]
.xx....x.....x................x...........x..............xx....x..xx.................x....xx.xx.......x..xxxxxxxx.xxx......x........x....x............x....s........s..............x....x....x [ 19%]
.x....x........x............x.......x................................x.....x.x.......x.......x..x....x...x......................x......x......x...........xx.....x............x...........x... [ 29%]
...x......x.........x...x..xx...........xx..x...........x....x.....xx.xx......x...x...xx....x..x..x..x..xxxxx...x......x..x.x...x....x....xx..xx.xx..xxxx.xx...x.....xxxx........x......x..... [ 38%]
.x.....x.x.....x.xx....x....xx..xxx.xx....xxx..x.......x..x..x...xx....xxx..x........x..x.x.x....x....x.x..x.....x....x....x.....x...................x............x..x..xx.x.x.x.xx.xx...x.x.x [ 48%]
.x...x...........x..x.........ssssss.ssssssssssssxxxx..........x.......x........x.xx.x....xx......x.x.sx..xx.............x..xx...x......x........x...............x...x..x....x........x.....x. [ 58%]
..x...x...x....xxxxxxxx......x....xx..x..x...xxx.xsssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssss......x..x..xx......xxxx..xxxsss.....xx.. [ 68%]
........x.......x.xxxx.......x.....x..............X...x...x.............xx...................xx....xx.....x.....x........x...x...................x......xx.....x.............x..........x..... [ 77%]
x.............................x.x....................x........x.......s.x.X......sx..........x...sx....x.....................x........x..x.x.xx......s........................s............... [ 87%]
..........................................x.......................................................................x..x....x.........x.........x...............x.x..xx............x....x.x..... [ 97%]
....................x....x...................x........                                                                                [100%]
1493 passed, 130 skipped, 329 xfailed, 2 xpassed in 823.56s (0:13:43)

Merging!

@cpcloud cpcloud enabled auto-merge (squash) March 3, 2025 16:28
@cpcloud cpcloud disabled auto-merge March 3, 2025 16:28
@cpcloud cpcloud merged commit 1829169 into ibis-project:main Mar 3, 2025
92 of 93 checks passed
@cpcloud cpcloud deleted the athena-ci-namespaces branch March 3, 2025 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
athena The Amazon Athena backend bug Incorrect behavior inside of ibis ci Continuous Integration issues or PRs ddl Issues related to creating or altering data definitions tests Issues or PRs related to tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant