Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(athena): use internal ibis APIs for creating testing data #10931

Merged

Conversation

cpcloud
Copy link
Member

@cpcloud cpcloud commented Mar 3, 2025

Clean up the test data loading in the athena conftest.py module

@github-actions github-actions bot added tests Issues or PRs related to tests athena The Amazon Athena backend labels Mar 3, 2025
@cpcloud
Copy link
Member Author

cpcloud commented Mar 3, 2025

Athena is passing

❯ pytest -m athena -n auto --snapshot-update -x -q
bringing up nodes...
...................................s............s........x.x.x....x.xxx..xx.....x...........xx.x.xx......x.X.........x..............x [  6%]
x..x..........x.....x.....x............x...x.......x....x.....x......x.xx..xx..........x......x....x......x..xx....x.s......xx....... [ 13%]
....x.....sssssssssssssssssssssssssssssssssssssssssssssssssssssssss.ssssssssssssssssssssssssssssss.x....s..............xx.....xxx...x [ 20%]
....xx...ssssssssssssxxxxxx..xxxxxxxxxxxx...x...xx....x.x...x........x...x....x.....xx.x.x..x........xx...x.....xx........sx.xx....xx [ 27%]
........x....x....xx..x.......x.x...................x.........................x.xx........x..s.......x.x............................. [ 34%]
x.x..x..x......................................x......x............x..xxx....x.....xx....xx..............x...............x...x.x..X.. [ 40%]
....x....x.....x...x.xxxx.x...xxx.x....x..x....x..xx....xxxxxxxxxxx.x.xx......x..x.xx.x....x.xx...xx.x.x.x..x.....x..x..x...........x [ 47%]
..x..x...x.x..x...x....xx........x...x....x....xx.................xx...........x.x.xxxxx....x......x.......x...x...xx.x..x.x.......x. [ 54%]
..x..x......xx.........xxx..xx..............xssss......sssssssssxxxxx.ssssssss...xxxxxxxx..xx.xxx.....x.........x......x............. [ 61%]
.....................x..x..............x.............xx........x................x..x.......x...x...x....x.xx....xx...x...x...x....x.x [ 68%]
x......x..xx..x...xx.x.......x...xx...........x.........................xx......x.....xx...x..................................x...... [ 74%]
.......x..........x.............x...x..............x...x...x..x...................x.........................s.x...xxx..x.x........... [ 81%]
x...x.x..xx...x.....................x...x......x...........x...x...............x..x.................x...ss.....................x...x. [ 88%]
.............x.......x............................................................................................................... [ 95%]
...............xx........x.x.....x...........x.......s......x..........xxx...xx...x.....xx.x                                          [100%]
1493 passed, 130 skipped, 329 xfailed, 2 xpassed in 858.35s (0:14:18)

@cpcloud cpcloud merged commit 83cb363 into ibis-project:main Mar 3, 2025
85 of 88 checks passed
@cpcloud cpcloud deleted the cleanup-create-table-in-athena-testing branch March 3, 2025 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
athena The Amazon Athena backend tests Issues or PRs related to tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant