Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(dev-tools): remove unnecessary all extra #8928

Merged
merged 1 commit into from
Apr 10, 2024
Merged

chore(dev-tools): remove unnecessary all extra #8928

merged 1 commit into from
Apr 10, 2024

Conversation

cpcloud
Copy link
Member

@cpcloud cpcloud commented Apr 10, 2024

Removes the all extra from pyproject.toml. The --all-extras flag now works across the board in poetry so this manually maintained extra is no longer necessary.

@cpcloud cpcloud added this to the 9.0 milestone Apr 10, 2024
@cpcloud cpcloud added dependencies Issues or PRs related to dependencies developer-tools Tools related to ibis development labels Apr 10, 2024
@cpcloud cpcloud requested a review from gforsyth April 10, 2024 14:57
gforsyth
gforsyth approved these changes Apr 10, 2024
View reviewed changes
Copy link
Member

@gforsyth gforsyth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@cpcloud cpcloud enabled auto-merge (squash) April 10, 2024 19:55
@cpcloud cpcloud merged commit 58e7573 into ibis-project:main Apr 10, 2024
87 checks passed
@cpcloud cpcloud deleted the remove-all-extra branch April 10, 2024 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gforsyth gforsyth gforsyth approved these changes

Assignees
No one assigned
Labels
dependencies Issues or PRs related to dependencies developer-tools Tools related to ibis development
Projects
None yet
Milestone
9.0
Development

Successfully merging this pull request may close these issues.
2 participants
@cpcloud @gforsyth