[pull] master from eggjs:master #18
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## master #18 +/- ##
=======================================
Coverage 99.85% 99.85%
=======================================
Files 35 35
Lines 3489 3489
Branches 512 512
=======================================
Hits 3484 3484
Misses 5 5 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
[skip ci] ## [3.16.0](v3.15.0...v3.16.0) (2023-05-10) ### Features * use [email protected] ([#5182](#5182)) ([a13b35e](a13b35e))
Add necessary detailled information for "Pulling code" and "Install Dependencies", especially for when npm's version >= 7.x, '--legacy-peer-deps' is always ignored by new comers, which will raise installation problems.
Add necessary detailled information for "Pulling code" and "Install Dependencies", especially for when npm's version >= 7.x, '--legacy-peer-deps' is always ignored by new comers, which will raise installation problems as a temporary solution.
After investigation for a while for windows, it seems we should delay for about 1 sec before the "assert" can find the actual error logged into the file.
1. Remove useless 'empty.txt'. 2. Combine some promises together as a chain to save time.
1. Typo fixes for "CONTRIBUTING.md" and "README.md" in both English and Chinese versions. 2. Add language switchers for "CONTRIBUTING.md" and "README.md" in both English and Chinese versions.
Add 'cross-env' to make sure we can run doc generation successfully on both win and mac, linux.
The 'httpclient-tracer' unit test cannot work properly, because "app" hasn't been initialized, we'll get an error when getting "httpclient". The solution is to get it in "beforeStart" in the app.js to have a test with.
Bug Reasons: 1. We cannot get "messenger" and "lifecycle" instances belonging to "app" itself before "ready()" function, a "cannot get xxx property" will be raised. 2. We CANNOT use "mm(……)" to replace "triggerServerDidReady" function, after "app.ready()", bcoz it WON'T be triggered if we do that. The only solution is to replace it in the constructor.
Now the stable version of nodejs is v18, upgrade it to the latest version to fix the bug of '--openssl-legacy-provider is not allowed in NODE_OPTIONS' in node v16.
1. Update "findlinks" to make the "doc.test.js" stable when rendering documents of Egg.js (Refs: popomore/findlinks#9). 2. Adjust the "utils.sleep()" to make sure the unit tests on non-windows platform stable. 3. Change the title and skip the test of doc generation for windows platform or nodejs's version < 18.
Our current nodejs version MUST BE >=14.20.0, no need to check whether the current version satisfies the test env.
The old link cannot sync the state of "CI", and now GitHub has re-newed its link, this is the fix for it. Refs: https://docs.github.com/en/actions/monitoring-and-troubleshooting-workflows/adding-a-workflow-status-badge#using-the-workflow-file-name
1. Update the Simplified Chinese version for some links. 2. Update the English ones (better syntax).
fix typos of trailing-spaces by autofix-bot to make all the md files formatted.
[skip ci] ## [3.16.1](v3.16.0...v3.16.1) (2023-06-15) ### Bug Fixes * ipc not work with worker_threads mode ([#5210](#5210)) ([03c8cf7](03c8cf7))
For Nodejs 20, we should use "await" to wait each of these threads finishing their task and then for a coming result.
Co-authored-by: William.Tung <[email protected]>
[skip ci] ## [3.17.0](v3.16.1...v3.17.0) (2023-06-19) ### Features * add getSingletonInstance alias to singleton.get(id) ([#5216](#5216)) ([9868768](9868768))
These files are temporarily created for initialization and they're now useless, remove them anyway.
Fix for some comments in the codes.
 <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Documentation** - Updated the Chinese tutorial for Socket.IO to remove outdated configuration comments. <!-- end of auto-generated comment: release notes by coderabbit.ai --> Co-authored-by: fengmk2 <[email protected]>
Co-authored-by: fengmk2 <[email protected]>
<!-- Thank you for your pull request. Please review below requirements. Bug fixes and new features should include tests and possibly benchmarks. Contributors guide: https://github.com/eggjs/egg/blob/master/CONTRIBUTING.md 感谢您贡献代码。请确认下列 checklist 的完成情况。 Bug 修复和新功能必须包含测试，必要时请附上性能测试。 Contributors guide: https://github.com/eggjs/egg/blob/master/CONTRIBUTING.md --> ##### Checklist <!-- Remove items that do not apply. For completed items, change [ ] to [x]. --> - [ ] `npm test` passes - [ ] tests and/or benchmarks are included - [ ] documentation is changed or added - [ ] commit message follows commit guidelines ##### Affected core subsystem(s) <!-- Provide affected core subsystem(s). --> ##### Description of change <!-- Provide a description of the change below this comment. --> <!-- - any feature? - close https://github.com/eggjs/egg/ISSUE_URL -->
auto fallback to urllib@3 when require urllib4 error <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Expanded CI workflow to include Node.js version 23 for testing. - Enhanced `HttpClientNext` class with improved error handling and configuration management. - Added support for HTTP/2 functionality in the test suite, including self-signed certificate handling. - **Bug Fixes** - Improved error handling for library imports based on Node.js versions. - **Chores** - Updated dependency versions in `package.json`. - Modified HTTP client configuration to include a new `connect` property. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
<!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit ## Release Notes - **New Features** - Introduced a new GitHub Actions workflow for releases on the `3.x` branch. - **Improvements** - Updated test coverage badges in both English and Chinese README files to reflect the `3.x` branch. - **Chores** - Adjusted the tagging strategy in the package configuration to mark future releases as "latest" instead of "release-3.x". <!-- end of auto-generated comment: release notes by coderabbit.ai -->
[skip ci] ## [3.30.0](v3.29.0...v3.30.0) (2025-01-09) ### Features * dump ignore support key path ([#5380](#5380)) ([74346c2](74346c2))
```bash node_modules/.store/[email protected]/node_modules/egg/index.d.ts:63:3 - error TS2666: Exports and export assignments are not permitted in module augmentations. 63 export { HttpClientRequestURL, HttpClientRequestOptions, HttpClientResponse }; ~~~~~~ Found 1 error in node_modules/.store/[email protected]/node_modules/egg/index.d.ts:63 ```
[skip ci] ## [3.30.1](v3.30.0...v3.30.1) (2025-01-19) ### Bug Fixes * redefine urllib export types ([#5386](#5386)) ([02d9fdb](02d9fdb))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )