-
Notifications
You must be signed in to change notification settings - Fork 36
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Drop Python 3.7 support and upgrade dependencies (#350)
## Description <!-- Provide a brief description of the PR's purpose here. --> Python 3.7 is now end of life; thus v0.6.0 will drop support for it. Note that most dependencies can remain the same since the versions we depend on support Python 3.7 and up, which includes Python 3.8. ## TODO <!-- Notable points that this PR has either accomplished or will accomplish. --> - [x] Upgrade all CI to use at least python 3.8 - [x] Update tags in [setup.py](http://setup.py/) - [x] Update documentation to only start at python 3.8 - [x] Upgrade scikit learn to 1.1.0 as we had a breaking change that we had to account for in cvt archive. This upgrade is feasible since scikit learn 1.1.0 requires Python 3.8+. This upgrade also allows us to remove semantic version as a dependency. - [x] Upgrade pinned reqs for visualize test to closely match the versions we develop with. This also necessitates updating the baseline images. ### Website - [x] Update website to mention supporting python 3.8 and up ## Questions <!-- Any concerns or points of confusion? --> ## Status - [x] I have read the guidelines in [CONTRIBUTING.md](https://github.com/icaros-usc/pyribs/blob/master/CONTRIBUTING.md) - [x] I have formatted my code using `yapf` - [x] I have tested my code by running `pytest` - [x] I have linted my code with `pylint` - [x] I have added a one-line description of my change to the changelog in `HISTORY.md` - [x] This PR is ready to go
- Loading branch information
Showing
18 changed files
with
41 additions
and
37 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
# Pinned Requirements | ||
|
||
This directory contains pinned requirements for testing pyribs on Python >= 3.7. | ||
This directory contains pinned requirements for testing pyribs on Python >= 3.8. | ||
In general, the requirements are as close to the minimum version from `setup.py` | ||
as possible. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,14 @@ | ||
# The reference images in the repo were created with Matplotlib 3.5.1 -- images | ||
# created with earlier versions are slightly different. | ||
matplotlib==3.5.1 | ||
# The reference images in the repo were created with these dependencies -- | ||
# in general, it's quite hard to make the visualization tests robust because | ||
# they are vulnerable to various API changes and even internal implementation | ||
# decisions of these libraries (e.g., changes in random number generator usage), | ||
# but by keeping these dependencies fairly recent, we can minimize these issues | ||
# since these are roughly the versions that we develop with. | ||
numpy==1.24.4 | ||
numba==0.57.1 | ||
pandas==2.0.3 | ||
sortedcontainers==2.4.0 | ||
scikit-learn==1.3.0 | ||
scipy==1.10.1 | ||
threadpoolctl==3.0.0 | ||
matplotlib==3.7.2 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,8 +1,7 @@ | ||
numpy==1.17.0 | ||
numpy==1.17.3 | ||
numba==0.51.0 | ||
pandas==1.0.0 | ||
sortedcontainers==2.0.0 | ||
scikit-learn==0.20.0 | ||
scikit-learn==1.1.0 | ||
scipy==1.4.0 | ||
threadpoolctl==3.0.0 | ||
semantic-version==2.10 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file modified
BIN
+38 Bytes
(100%)
tests/visualize/baseline_images/visualize_test/cvt_archive_heatmap.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-1.63 KB
(98%)
tests/visualize/baseline_images/visualize_test/cvt_archive_heatmap_long.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-257 Bytes
(100%)
tests/visualize/baseline_images/visualize_test/cvt_archive_heatmap_long_square.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-11 Bytes
(100%)
...visualize/baseline_images/visualize_test/cvt_archive_heatmap_long_transpose.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+18 Bytes
(100%)
...visualize/baseline_images/visualize_test/cvt_archive_heatmap_with_centroids.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+55 Bytes
(100%)
...alize/baseline_images/visualize_test/cvt_archive_heatmap_with_coolwarm_cmap.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+69 Bytes
(100%)
tests/visualize/baseline_images/visualize_test/cvt_archive_heatmap_with_limits.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+465 Bytes
(100%)
...sualize/baseline_images/visualize_test/cvt_archive_heatmap_with_listed_cmap.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-184 Bytes
(100%)
...s/visualize/baseline_images/visualize_test/cvt_archive_heatmap_with_samples.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.