Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update actions/upload-artifact for deprecated version #47

Merged
merged 7 commits into from
Feb 8, 2025
Merged

chore: update actions/upload-artifact for deprecated version #47

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
35230a6
chore: update actions/upload-artifact for deprecated version
ClarkXia Feb 8, 2025
18f8f68
fix: update corepack
ClarkXia Feb 8, 2025
d626882
fix: ci
ClarkXia Feb 8, 2025
32d8c3a
fix: optimize ci
ClarkXia Feb 8, 2025
d17b081
fix: ci
ClarkXia Feb 8, 2025
a352556
fix: ci
ClarkXia Feb 8, 2025
81be3b6
fix: ci
ClarkXia Feb 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,9 @@ jobs:
name: linux-x64-gnu
docker: ghcr.io/napi-rs/napi-rs/nodejs-rust:lts-debian
build: |-
npm install -g corepack@latest &&
corepack enable &&
pnpm --version &&
set -e &&
cd crates/node_binding &&
unset CC_x86_64_unknown_linux_gnu && unset CC &&
Expand All @@ -79,6 +82,9 @@ jobs:
name: linux-arm64-gnu
docker: ghcr.io/napi-rs/napi-rs/nodejs-rust:lts-debian-aarch64
build: |-
npm install -g corepack@latest &&
corepack enable &&
pnpm --version &&
set -e &&
cd crates/node_binding &&
export JEMALLOC_SYS_WITH_LG_PAGE=16 && export CC_aarch64_unknown_linux_gnu=clang &&
Expand Down Expand Up @@ -141,7 +147,7 @@ jobs:
if: ${{ !matrix.settings.docker }}
shell: bash
- name: Upload artifact
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: ${{ env.APP_NAME }}.${{ matrix.settings.name }}.node
path: crates/node_binding/${{ env.APP_NAME }}.*.node
Expand All @@ -156,19 +162,19 @@ jobs:
- name: Pnpm Cache # Required by some tests
uses: ./.github/actions/pnpm-cache
- name: Download macOS x64 artifact
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
name: ${{ env.APP_NAME }}.darwin-x64.node
path: crates/node_binding/artifacts
- name: Download macOS arm64 artifact
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
name: ${{ env.APP_NAME }}.darwin-arm64.node
path: crates/node_binding/artifacts
- name: Combine binaries
run: cd crates/node_binding && pnpm universal
- name: Upload artifact
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: ${{ env.APP_NAME }}.darwin-universal.node
path: crates/node_binding/${{ env.APP_NAME }}.*.node
Expand All @@ -183,7 +189,7 @@ jobs:
- name: Pnpm Cache # Required by some tests
uses: ./.github/actions/pnpm-cache
- name: Download all artifacts
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
path: crates/node_binding/artifacts
- name: Move artifacts
Expand Down