Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support modify vendor name #597

Merged
merged 7 commits into from
Sep 25, 2023
Merged

Conversation

luhc228
Copy link
Member

@luhc228 luhc228 commented Sep 15, 2023

bundle 模式下,如果不同的 task(比如一个 weex,一个 web )均产生 vendor,因为 vendor 文件同名的原因,那么后面产出的 vendor 会覆盖掉前面的 vendor。

因此需要支持每个 task 定制自己的 vendor name

@vercel
Copy link

vercel bot commented Sep 15, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
icepkg ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 25, 2023 3:29am

@luhc228 luhc228 changed the title feat: support modify vendors name feat: support modify vendor name Sep 15, 2023
@luhc228 luhc228 self-assigned this Sep 15, 2023
@luhc228 luhc228 added the need review Need Review label Sep 15, 2023
@ChrisCindy
Copy link
Collaborator

如果用户不配置 modifyVendorName,默认是不是也可以根据 task name 修改一下 vendor name,避免出现冲突

ClarkXia
ClarkXia previously approved these changes Sep 22, 2023
ChrisCindy
ChrisCindy previously approved these changes Sep 22, 2023
@luhc228
Copy link
Member Author

luhc228 commented Sep 25, 2023

Updated version and changelog. Will merge to main directly.

@luhc228 luhc228 merged commit 1596db0 into main Sep 25, 2023
3 checks passed
@luhc228 luhc228 deleted the feat/support-modify-vendors-name branch September 25, 2023 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need review Need Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants