-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
basic IME support rebase #1858
base: master
Are you sure you want to change the base?
basic IME support rebase #1858
Conversation
I tracked this pr daily, hope to see it will be merged into main brach some day. |
Work related to IME is slated around the I will take a look at this by then! |
merge upstream
…into ime_adavanced_text
Thank you for working on this. This is a mandatory feature for CJK users. I tried this branch on macOS and I found one small issue. When some character was already input before a cursor, the insert position of IME candidates was a bit wrong. test.mov
After selecting the candidate, the text かきくけこ is inserted at correct position. So only the position of IME candidate is wrong. |
…into latest_master_1112
It seems fine for me
We can't measure width of IME candidate window. |
iced now using winit 0.28.6 fork. |
MERGE UPSTREAM
Awesome work! |
Hi, I understand that IME is scheduled for a later release in the roadmap, but it is a crucial feature for me and many others. Please consider moving IME to an earlier release. What is still needed before this feature can be merged? Thank you for the incredible work! |
@hecrj |
is it support text_editor? |
@Gezx |
@KentaTheBugMaker Hey bro, are you still working on this? |
@bioinformatist
Iced side also have problem. if want to support TextEdit widget we need to support below
current design have these difficulties.
so I'm re implementing this with better GTK IMContext like API.
New design .
|
I want to express my deep thanks for your continued effort on this. |
@KentaTheBugMaker Really appreciate! |
progress |
General
This PR fix #979,#1544.
iced ime support was broken due to winit 0.27 update .
This PR add event to fit new winit IME event model and introduce new event support for text_input.
how to test
download app from my repo https://github.com/KentaTheBugMaker/iced_text_input_sample/
Phase 1 : Can we input CJK characters?
tested on
Phase 2 : Candidate position is near the TextInput?
You maybe failed to reproduce due to IME version.
candidate positon on X11 require LibX11 1.8.2 or above.
Wayland requirement.
tested on
Phase 3 draw underline and cursor
behavior
2022-12-05.23-27-59.mp4
test
not required.
We render underline and cursor correctly if winit correctly report it.
Note
I don't have a macos device, so if you notice any problems, macos users please fix them.
Some tests were done by other users. but Iced rework enforce me to reimplement completely.
Therefore old tests are not compatible with this version.
feel free to reimplement this.