-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Testing ATL14 gridded land ice download from earthdata #289
Open
weiji14
wants to merge
14
commits into
development
Choose a base branch
from
atl14-data-download
base: development
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
2a84dfb
Add test for ATL14 gridded land ice download from earthdata
weiji14 2feaf5d
Temporarily allow behind Earthdata tests
weiji14 65cfdac
Merge branch 'development' into atl14-data-download
weiji14 558c2c4
Update spatial extent to Svalbard
weiji14 f4b9413
Merge branch 'development' into atl14-data-download
weiji14 53f8652
Set pytest verbose mode for tests_behind_NSIDC_API_login
weiji14 8010274
Use for loop instead of list comprehension to see what keys are missing
weiji14 61f5fcd
Update ATL06 options json file to v06
weiji14 d4bc85f
[nsidc_tests] Disable tests behind NSIDC login on PR branch
weiji14 ba7b4f3
Merge branch 'development' into atl14-data-download
weiji14 a813fa4
[nsidc_tests] Remove setting of NSIDC_LOGIN environment variable
weiji14 a326c8d
[nsidc_tests] Revert "Remove setting of NSIDC_LOGIN environment varia…
weiji14 bfa3d88
GitHub action UML generation auto-update
rwegener2 538729b
Merge branch 'development' into atl14-data-download
JessicaS11 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@weiji14 If I'm understanding this right, we've added ATL14 as part of the fixture, but then don't actually run any tests on it beyond creating a query object with those parameters (in which case, shouldn't we just create a query object with it elsewhere instead of in
test_behind_NSIDC_API_login.py
). That or the assertions in lines 50-51 will fail because there's no appropriate json file for the ATL14 custom options...