Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

properly apply all dimensions to deeply nested variables #623

Merged
merged 4 commits into from
Nov 14, 2024

Conversation

JessicaS11
Copy link
Member

In debugging #620, it turned out that variables with a fourth layer of nesting (e.g. ATL06's gt2r/land_ice_segments/geophysical/bsnow_h) were being added to the Xarray Dataset but missing some of their dimensions. This PR addresses that by adding any dimension of size 1 in the subgroup-read-in step to that variable before merging it with the multi-granule dataset. This allows per-granule datasets to be properly merged automatically (rather than icepyx returning a list of per-granule datasets).

Copy link

github-actions bot commented Oct 25, 2024

Binder 👈 Launch a binder notebook on this branch for commit 4a21836

I will automatically update this comment whenever this PR is modified

Binder 👈 Launch a binder notebook on this branch for commit 7571adb

Binder 👈 Launch a binder notebook on this branch for commit 4514fd2

Copy link

codecov bot commented Oct 25, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 66.77%. Comparing base (50af59d) to head (4514fd2).
Report is 1 commits behind head on development.

Files with missing lines Patch % Lines
icepyx/core/read.py 0.00% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (50af59d) and HEAD (4514fd2). Click for more details.

HEAD has 23 uploads less than BASE
Flag BASE (50af59d) HEAD (4514fd2)
25 2
Additional details and impacted files
@@               Coverage Diff               @@
##           development     #623      +/-   ##
===============================================
- Coverage        71.81%   66.77%   -5.04%     
===============================================
  Files               38       36       -2     
  Lines             3136     3079      -57     
  Branches           426      426              
===============================================
- Hits              2252     2056     -196     
- Misses             774      936     +162     
+ Partials           110       87      -23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JessicaS11 JessicaS11 merged commit 4539e82 into development Nov 14, 2024
7 of 10 checks passed
@JessicaS11 JessicaS11 deleted the nested-var-dims branch November 14, 2024 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant