Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

using std::foo #73

Merged
merged 1 commit into from
Nov 29, 2023
Merged

using std::foo #73

merged 1 commit into from
Nov 29, 2023

Conversation

mgates3
Copy link
Collaborator

@mgates3 mgates3 commented Nov 8, 2023

Do

    using std::sqrt;
    y = sqrt( x );

instead of

    y = std::sqrt( x );

and similar functions, when x is a user-defined type (scalar_t). Resolves #43.

…milar functions, when x is a user-defined type (scalar_t). Resolves icl-utk-edu#43.
Copy link
Contributor

@ayarkhan ayarkhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it was intentional, but I left a note in test/test_scal_device.cc
where a std::max was replaced by blas::max.
Approved.

test/test_scal_device.cc Show resolved Hide resolved
@mgates3 mgates3 merged commit 577b5b1 into icl-utk-edu:master Nov 29, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do not call numeric functions with std:: prefix
2 participants