Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use to_blas_int to check overflow and convert int64_t #88

Merged
merged 1 commit into from
Oct 26, 2024

Conversation

mgates3
Copy link
Collaborator

@mgates3 mgates3 commented Oct 26, 2024

Updates rot, rotm. Other routines already used to_blas_int. Check files:

blaspp/src> git re -l '\bblas_int\b' | xargs grep -L to_blas_int

blaspp/src> git re -l '\bdevice_blas_int\b' | xargs grep -L to_device_blas_int
cublas_wrappers.cc
device_utils.cc
onemkl_wrappers.cc
rocblas_wrappers.cc

blaspp/src> git re numeric_limits
blas_internal.hh:        blas_error_if_msg( x > std::numeric_limits<blas_int>::max(), "%s", x_str );
device_internal.hh:        blas_error_if_msg( std::abs( x ) > std::numeric_limits<device_blas_int>::max(),

Copy link
Collaborator Author

@mgates3 mgates3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed.

@mgates3 mgates3 merged commit 3811be2 into icl-utk-edu:master Oct 26, 2024
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant