rocm: add known problems with some events to README #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbarry9
reviewed
Nov 9, 2023
src/components/rocm/README.md
Outdated
| @@ -85,6 +85,20 @@ setting the ROCP\_TOOL\_LIB to the PAPI library as follows: | |||
|
|
|||
| The binary image of a `double` is intact; but users must recast to `double` for display purposes. | |||
|
|
|||
| * The following ROCm events are known to cause an error when the rocm component is used in sampling mode | |||
|
|
|||
| TA_BUSY_{sum,avr,min,max} | |||
There was a problem hiding this comment.
A similar memory access fault occurs with the event "TCP_TCC_NC_ATOMIC_REQ_sum." Perhaps re-word the README to not specify just the TA_BUSY_* events.
There was a problem hiding this comment.
I changed the wording. Can you also create an issue that we can reference in the PR?
gcongiu
force-pushed
the
2023.11.09_rocm-known-problems
branch
from
6570cdf to
15ddb92
Compare
gcongiu
changed the title
dbarry9
reviewed
Nov 9, 2023
gcongiu
force-pushed
the
2023.11.09_rocm-known-problems
branch
from
15ddb92 to
37bc995
Compare
dbarry9
approved these changes
Nov 9, 2023
|
the rending is off with these changes:
|
gcongiu
force-pushed
the
2023.11.09_rocm-known-problems
branch
from
37bc995 to
54bf0af
Compare
bertwesarg
reviewed
Nov 11, 2023
Comment on lines
+92
to
+100
| $ papi_command_line TA_BUSY_avr | ||
|
|
||
| This utility lets you add events from the command line interface to see if they work. | ||
|
|
||
| Successfully added: rocm:::TA_BUSY_avr:device=0 | ||
|
|
||
| Memory access fault by GPU node-4 (Agent handle: 0x46d6d10) on address 0x7ffed888c000. Reason: Unknown. | ||
| Aborted |
There was a problem hiding this comment.
I assume, this should be some input and output in a terminal, but thats not how it will render.
Suggested change
| $ papi_command_line TA_BUSY_avr | |
| This utility lets you add events from the command line interface to see if they work. | |
| Successfully added: rocm:::TA_BUSY_avr:device=0 | |
| Memory access fault by GPU node-4 (Agent handle: 0x46d6d10) on address 0x7ffed888c000. Reason: Unknown. | |
| Aborted | |
| ```console | |
| $ papi_command_line TA_BUSY_avr | |
| This utility lets you add events from the command line interface to see if they work. | |
| Successfully added: rocm:::TA_BUSY_avr:device=0 | |
| Memory access fault by GPU node-4 (Agent handle: 0x46d6d10) on address 0x7ffed888c000. Reason: Unknown. | |
| Aborted | |
| ```` |
src/components/rocm/README.md
Outdated
| @@ -85,6 +85,21 @@ setting the ROCP\_TOOL\_LIB to the PAPI library as follows: | |||
|
|
|||
| The binary image of a `double` is intact; but users must recast to `double` for display purposes. | |||
|
|
|||
| * Some of the ROCm events are known to cause an error when the rocm component is used in sampling mode | |||
|
|
|||
| For example TA_BUSY_avr | |||
There was a problem hiding this comment.
Suggested change
| For example TA_BUSY_avr | |
| For example `TA_BUSY_avr` |
gcongiu
force-pushed
the
2023.11.09_rocm-known-problems
branch
from
54bf0af to
c092407
Compare
gcongiu
force-pushed
the
2023.11.09_rocm-known-problems
branch
from
c092407 to
e4cac74
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Author Checklist
Why this PR exists. Reference all relevant information, including background, issues, test failures, etc
Commits are self contained and only do one thing
Commits have a header of the form:
module: short descriptionCommits have a body (whenever relevant) containing a detailed description of the addressed problem and its solution
The PR needs to pass all the tests