sysdetect: accounting for missing core ids. #269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 23, 2024
gcongiu
reviewed
Oct 30, 2024
| @@ -119,8 +119,10 @@ fill_cpu_info( _sysdetect_cpu_info_t *info ) | |||
| } | |||
|
|
|||
| for (a = 0; a < info->threads * info->cores * info->sockets; ++a) { | |||
| CPU_CALL(cpu_get_attribute_at(CPU_ATTR__HWTHREAD_NUMA_AFFINITY, a, &info->numa_affinity[a]), | |||
| info->numa_affinity[a] = 0); | |||
There was a problem hiding this comment.
Instead of setting numa_affinity[a]=0 in case of error we could have set it to -1 here?
gcongiu
approved these changes
Oct 30, 2024
|
I've just tested this on an Intel Raptorlake machine with heterogeneous cores, and it fixes #256. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Some systems have non-contiguous numbering of cores, which affects the way we count the number of cores each numa node has.
Author Checklist
Why this PR exists. Reference all relevant information, including background, issues, test failures, etc
Commits are self contained and only do one thing
Commits have a header of the form:
module: short descriptionCommits have a body (whenever relevant) containing a detailed description of the addressed problem and its solution
The PR needs to pass all the tests