feat: cosmwasm contracts #10
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sherpalden
reviewed
Feb 13, 2025
| } | ||
|
|
||
| pub fn is_native(&self, deps: Deps, denom: &String) -> bool { | ||
| if let Ok(addr) = deps.api.addr_validate(denom) { |
There was a problem hiding this comment.
What happens in case of invalid token address? Also the func param name denom seems misleading.
sherpalden
reviewed
Feb 13, 2025
| self.nid.load(storage) | ||
| } | ||
|
|
||
| pub fn get_protocol_fee(&self, storage: &dyn Storage) -> StdResult<u8> { |
There was a problem hiding this comment.
u8 will only allow for [0,255] out of 10,000 scale. Is this an issue?
sherpalden
reviewed
Feb 13, 2025
| msg: ExecuteMsg, | ||
| ) -> Result<Response, ContractError> { | ||
| let call_service = CwIntentV1Service::default(); | ||
| match msg { |
sherpalden
reviewed
Feb 13, 2025
| solver_address: order.creator.clone(), | ||
| }; | ||
| let msg = OrderMsg { | ||
| msg_type: ORDER_CANCEL, |
There was a problem hiding this comment.
I think the message type should ORDER_FILL.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Commit Message
see the guidelines for commit messages.
Changelog Entry
Checklist: