Add the CompileListener from game-ci to create github annotations of errors and warnings #561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikeage
force-pushed
the
compilelistener
branch
from
31e65b5 to
12f3edc
Compare
Note that originally, this PR attempted to use variables, not secrets, for the fallback license. The documentation implies that these should be available, but in fact, they're not. See, for example, https://github.com/orgs/community/discussions/44322 Given an .ulf file, it can be converted to the format here using: cat foo.ulf | sed -e 's/"/\\"/g' -e ':a;N;$!ba;s/\n/\\n/g' On a Mac, use gsed instead of sed ==== OLD COMMIT MESSAGE ==== Get personal license from Github vars Action v4 requires always passing the username and password. We'll get this from a Github var instead of embedding it To set these variables, follow the instructions at https://game.ci/docs/github/activation/#personal-license to set up Unity Hub. Then, save the following environment variables at https://github.com/icosa-foundation/open-brush/settings/variables/actions: FALLBACK_UNITY_EMAIL FALLBACK_UNITY_PASSWORD FALLBACK_UNITY_LICENSE Note that for the license, you need to do two search and replaces first: 1. s/"/\\"/g # Replace all instances of " with \" 2. s/\r/\\n/g # Replace all newlines with a string of \n After this commit, PRs from forks will build successfully using the FALLBACK_* credentials. Users who wish to build on their fork, using the "[CI BUILD]" option, will need to set these environment variables at their settings/variables/actions link. The ones from Icosa will only be used when building as part of a PR, not as part of a local commit. ==== END OLD COMMIT MESSAGE ==== ==== ORIGINAL CHANGE ==== + UNITY_EMAIL: ${{ fromJSON(format('["{0}", "{1}"]', vars.FALLBACK_UNITY_EMAIL, secrets.UNITY_EMAIL))[secrets.UNITY_SERIAL != null] }} + UNITY_PASSWORD: ${{ fromJSON(format('["{0}", "{1}"]', vars.FALLBACK_UNITY_PASSWORD, secrets.UNITY_PASSWORD))[secrets.UNITY_SERIAL != null] }} + UNITY_LICENSE: ${{ fromJSON(format('["{0}", null]', vars.FALLBACK_UNITY_LICENSE))[secrets.UNITY_SERIAL != null] }} ==== END ORIGINAL CHANGE ====
…errors and warnings
mikeage
force-pushed
the
compilelistener
branch
from
12f3edc to
6cf7f71
Compare
|
This creates notes on the Summary section, but not on the review, doesn't link to the actual source, and seems to report those same errors that aren't actually blocking anything. In short, I don't think we want this. Closing for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.