Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry build on license acquisition failure #571

Merged
merged 4 commits into from
Nov 28, 2023

Conversation

mikeage
Copy link
Member

@mikeage mikeage commented Nov 25, 2023

Reverts #570

The unity-builder action now exposes the exit code of the call to Unity.
License failure results in an exit code of 1. In this case, call a new
step to try to rerun it.

It seems like no other errors return 1. I tried both a syntax error and
an invalid package. Both returned 133.

@mikeage mikeage self-assigned this Nov 25, 2023
@mikeage mikeage marked this pull request as draft November 25, 2023 20:13
@mikeage
Copy link
Member Author

mikeage commented Nov 25, 2023

Currently testing from a branch, but I'll update this PR once it's merged, if it works well.

@mikeage mikeage changed the title Use official game-ci unity-builder action again Retry build on license acquisition failure Nov 28, 2023
The unity-builder action now exposes the exit code of the call to Unity.
License failure results in an exit code of 1. In this case, call a new
step to try to rerun it.

It seems like no other errors return 1. I tried both a syntax error and
an invalid package. Both returned 133.
@mikeage mikeage force-pushed the infra/newest_game_ci branch from 19d04da to fbd7ca9 Compare November 28, 2023 06:09
@mikeage
Copy link
Member Author

mikeage commented Nov 28, 2023

This is actually ready, in principle, but I want the game-ci team to merge the branch and to take the action from a tag, not a branch. edit: v4 updated to point to v4.1.1

Sample showing the retry: https://github.com/icosa-foundation/open-brush/actions/runs/7014872586

@mikeage mikeage added the infrastructure Build or tooling infrastructure label Nov 28, 2023
@mikeage mikeage marked this pull request as ready for review November 28, 2023 09:32
@mikeage mikeage merged commit 582d3b2 into icosa-foundation:main Nov 28, 2023
20 checks passed
@mikeage mikeage deleted the infra/newest_game_ci branch November 28, 2023 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure Build or tooling infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant