Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: section table body row #1102

Merged
merged 6 commits into from
Jan 9, 2025
Merged

refactor: section table body row #1102

merged 6 commits into from
Jan 9, 2025

Conversation

KevinWu098
Copy link
Member

Summary

  1. Extracts row cells into individual components
  2. Removes withStyle
  3. Migrates to MUI v5

Test Plan

  1. Add a course, yellow highlight should be present
  2. Add a course, other courses at the same time should be darkened if they conflict
  3. Clicking blue links / text should still do the appropriate functionality
  4. The row should look the same as it did before

Issues

Part of #1068, chunking out the refactor first

@KevinWu098 KevinWu098 requested a review from jotalis January 9, 2025 00:16
jotalis
jotalis approved these changes Jan 9, 2025
View reviewed changes
Copy link
Contributor

@jotalis jotalis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@KevinWu098 KevinWu098 requested a review from jotalis January 9, 2025 00:44
jotalis
jotalis approved these changes Jan 9, 2025
View reviewed changes
Copy link
Contributor

@jotalis jotalis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@KevinWu098 KevinWu098 merged commit 5b7745b into main Jan 9, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jotalis jotalis jotalis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KevinWu098 @jotalis